language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-30 23:38:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)

Browse source 
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten 
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`. 
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in: 
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and 
in some cases might result in a significant size difference for the 
snapshot. As an example, in "deno_node" extension, we store the 
source code in "polyfills" directory; which resulted in each specifier 
to look like "internal:deno_node/polyfills/<module_name>", but with 
this change it's "internal:deno_node/<module_name>". 

Given that "deno_node" has over 100 files, many of them having 
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
This commit is contained in:
Bartek Iwańczuk 2023-03-04 22:31:38 -04:00 • committed by GitHub
parent 01028fcdf4
commit b40086fd7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
219 changed files with 1205 additions and 1273 deletions
Download patch file Download diff file Expand all files Collapse all files

16
ext/node/polyfills/internal/console/constructor.mjs
View file

@ -8,12 +8,12 @@ import {
ERR_INCOMPATIBLE_OPTION_PAIR,
ERR_INVALID_ARG_VALUE,
isStackOverflowError,
} from "internal:deno_node/polyfills/internal/errors.ts";
} from "internal:deno_node/internal/errors.ts";
import {
validateArray,
validateInteger,
validateObject,
} from "internal:deno_node/polyfills/internal/validators.mjs";
} from "internal:deno_node/internal/validators.mjs";
const previewEntries = (iter, isKeyValue) => {
if (isKeyValue) {
const arr = [...iter];
@ -25,24 +25,24 @@ const previewEntries = (iter, isKeyValue) => {
return [...iter];
}
};
import { Buffer } from "internal:deno_node/polyfills/buffer.ts";
import { Buffer } from "internal:deno_node/buffer.ts";
const { isBuffer } = Buffer;
import { formatWithOptions, inspect } from "internal:deno_node/polyfills/internal/util/inspect.mjs";
import { formatWithOptions, inspect } from "internal:deno_node/internal/util/inspect.mjs";
import {
isMap,
isMapIterator,
isSet,
isSetIterator,
isTypedArray,
} from "internal:deno_node/polyfills/internal/util/types.ts";
} from "internal:deno_node/internal/util/types.ts";
import {
CHAR_LOWERCASE_B as kTraceBegin,
CHAR_LOWERCASE_E as kTraceEnd,
CHAR_LOWERCASE_N as kTraceInstant,
CHAR_UPPERCASE_C as kTraceCount,
} from "internal:deno_node/polyfills/internal/constants.ts";
import { clearScreenDown, cursorTo } from "internal:deno_node/polyfills/internal/readline/callbacks.mjs";
import cliTable from "internal:deno_node/polyfills/internal/cli_table.ts";
} from "internal:deno_node/internal/constants.ts";
import { clearScreenDown, cursorTo } from "internal:deno_node/internal/readline/callbacks.mjs";
import cliTable from "internal:deno_node/internal/cli_table.ts";
const kCounts = Symbol("counts");
const kTraceConsoleCategory = "node,node.console";