language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-07-24 05:35:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)

Browse source 
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten 
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`. 
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in: 
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and 
in some cases might result in a significant size difference for the 
snapshot. As an example, in "deno_node" extension, we store the 
source code in "polyfills" directory; which resulted in each specifier 
to look like "internal:deno_node/polyfills/<module_name>", but with 
this change it's "internal:deno_node/<module_name>". 

Given that "deno_node" has over 100 files, many of them having 
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
This commit is contained in:
Bartek Iwańczuk 2023-03-04 22:31:38 -04:00 • committed by GitHub
parent 01028fcdf4
commit b40086fd7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
219 changed files with 1205 additions and 1273 deletions
Download patch file Download diff file Expand all files Collapse all files

6
runtime/js/98_global_scope.js
View file

@ -7,7 +7,7 @@ const {
SymbolFor,
} = primordials;
import * as util from "internal:runtime/js/06_util.js";
import * as util from "internal:runtime/06_util.js";
import * as location from "internal:deno_web/12_location.js";
import * as event from "internal:deno_web/02_event.js";
import * as timers from "internal:deno_web/02_timers.js";
@ -16,7 +16,7 @@ import * as encoding from "internal:deno_web/08_text_encoding.js";
import * as console from "internal:deno_console/02_console.js";
import * as caches from "internal:deno_cache/01_cache.js";
import * as compression from "internal:deno_web/14_compression.js";
import * as worker from "internal:runtime/js/11_workers.js";
import * as worker from "internal:runtime/11_workers.js";
import * as performance from "internal:deno_web/15_performance.js";
import * as crypto from "internal:deno_crypto/00_crypto.js";
import * as url from "internal:deno_url/00_url.js";
@ -39,7 +39,7 @@ import DOMException from "internal:deno_web/01_dom_exception.js";
import * as abortSignal from "internal:deno_web/03_abort_signal.js";
import * as globalInterfaces from "internal:deno_web/04_global_interfaces.js";
import * as webStorage from "internal:deno_webstorage/01_webstorage.js";
import * as prompt from "internal:runtime/js/41_prompt.js";
import * as prompt from "internal:runtime/41_prompt.js";
// https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope
const windowOrWorkerGlobalScope = {