language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 12:19:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019)

Browse source 
This commit changes "include_js_files!" macro from "deno_core"
in a way that "dir" option doesn't cause specifiers to be rewritten 
to include it.

Example:
```
include_js_files! {
  dir "js",
  "hello.js",
}
```

The above definition required embedders to use:
`import ... from "internal:<ext_name>/js/hello.js"`. 
But with this change, the "js" directory in which the files are stored
is an implementation detail, which for embedders results in: 
`import ... from "internal:<ext_name>/hello.js"`.

The directory the files are stored in, is an implementation detail and 
in some cases might result in a significant size difference for the 
snapshot. As an example, in "deno_node" extension, we store the 
source code in "polyfills" directory; which resulted in each specifier 
to look like "internal:deno_node/polyfills/<module_name>", but with 
this change it's "internal:deno_node/<module_name>". 

Given that "deno_node" has over 100 files, many of them having 
several import specifiers to the same extension, this change removes
10 characters from each import specifier.
This commit is contained in:
Bartek Iwańczuk 2023-03-04 22:31:38 -04:00 • committed by GitHub
parent 01028fcdf4
commit b40086fd7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
219 changed files with 1205 additions and 1273 deletions
Download patch file Download diff file Expand all files Collapse all files

14
runtime/js/99_main.js
View file

@ -39,12 +39,12 @@ const {
WeakMapPrototypeGet,
WeakMapPrototypeSet,
} = primordials;
import * as util from "internal:runtime/js/06_util.js";
import * as util from "internal:runtime/06_util.js";
import * as event from "internal:deno_web/02_event.js";
import * as location from "internal:deno_web/12_location.js";
import * as build from "internal:runtime/js/01_build.js";
import * as version from "internal:runtime/js/01_version.ts";
import * as os from "internal:runtime/js/30_os.js";
import * as build from "internal:runtime/01_build.js";
import * as version from "internal:runtime/01_version.ts";
import * as os from "internal:runtime/30_os.js";
import * as timers from "internal:deno_web/02_timers.js";
import * as colors from "internal:deno_console/01_colors.js";
import * as net from "internal:deno_net/01_net.js";
@ -57,8 +57,8 @@ import * as performance from "internal:deno_web/15_performance.js";
import * as url from "internal:deno_url/00_url.js";
import * as fetch from "internal:deno_fetch/26_fetch.js";
import * as messagePort from "internal:deno_web/13_message_port.js";
import { denoNs, denoNsUnstable } from "internal:runtime/js/90_deno_ns.js";
import { errors } from "internal:runtime/js/01_errors.js";
import { denoNs, denoNsUnstable } from "internal:runtime/90_deno_ns.js";
import { errors } from "internal:runtime/01_errors.js";
import * as webidl from "internal:deno_webidl/00_webidl.js";
import DOMException from "internal:deno_web/01_dom_exception.js";
import * as flash from "internal:deno_flash/01_http.js";
@ -70,7 +70,7 @@ import {
unstableWindowOrWorkerGlobalScope,
windowOrWorkerGlobalScope,
workerRuntimeGlobalProperties,
} from "internal:runtime/js/98_global_scope.js";
} from "internal:runtime/98_global_scope.js";
let windowIsClosing = false;
let globalThis_;