language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 10:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ext/node): support read-only database in node:sqlite (#27930)

Browse source 
Implements the `readOnly` option for `DatabaseSync`.

Permissions:
`--allow-read=test.db --allow-write=test.db` => all works
`--allow-read=test.db` => only `readOnly` dbs work, cannot create new db
This commit is contained in:
Divy Srivastava 2025-02-03 16:41:45 +05:30 • committed by GitHub
parent 7107c358a1
commit b5c3f4f782
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 55 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/unit_node/sqlite_test.ts
View file

@ -2,6 +2,8 @@
import { DatabaseSync } from "node:sqlite";
import { assert, assertEquals, assertThrows } from "@std/assert";
const tempDir = Deno.makeTempDirSync();
Deno.test("[node/sqlite] in-memory databases", () => {
const db1 = new DatabaseSync(":memory:");
const db2 = new DatabaseSync(":memory:");
@ -40,7 +42,6 @@ Deno.test(
name: "[node/sqlite] PRAGMAs are supported",
},
() => {
const tempDir = Deno.makeTempDirSync();
const db = new DatabaseSync(`${tempDir}/test.db`);
assertEquals(db.prepare("PRAGMA journal_mode = WAL").get(), {
@ -99,5 +100,31 @@ Deno.test({
assertThrows(() => {
new DatabaseSync("test.db");
}, Deno.errors.NotCapable);
assertThrows(() => {
new DatabaseSync("test.db", { readOnly: true });
}, Deno.errors.NotCapable);
},
});
Deno.test({
name: "[node/sqlite] readOnly database",
permissions: { read: true, write: true },
fn() {
{
const db = new DatabaseSync(`${tempDir}/test3.db`);
db.exec("CREATE TABLE foo (id INTEGER PRIMARY KEY)");
db.close();
}
{
const db = new DatabaseSync(`${tempDir}/test3.db`, { readOnly: true });
assertThrows(
() => {
db.exec("CREATE TABLE test(key INTEGER PRIMARY KEY)");
},
Error,
"attempt to write a readonly database",
);
db.close();
}
},
});