language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-07-24 13:44:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(npm): improve error message importing non-existent file in a node_modules npm package (#19835)

Browse source
This commit is contained in:
David Sherret 2023-07-14 13:47:15 -04:00 • committed by GitHub
parent 0223ad72a9
commit b83dac3b14
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
cli/npm/resolvers/local.rs
View file

@ -14,6 +14,7 @@ use std::sync::Arc;
use crate::cache::CACHE_PERM;
use crate::npm::cache::mixed_case_package_name_decode;
use crate::util::fs::atomic_write_file;
use crate::util::fs::canonicalize_path_maybe_not_exists_with_fs;
use crate::util::fs::symlink_dir;
use crate::util::fs::LaxSingleProcessFsFlag;
use crate::util::progress_bar::ProgressBar;
@ -112,9 +113,13 @@ impl LocalNpmPackageResolver {
match self.maybe_resolve_folder_for_specifier(specifier) {
// Canonicalize the path so it's not pointing to the symlinked directory
// in `node_modules` directory of the referrer.
Some(path) => {
Ok(deno_core::strip_unc_prefix(self.fs.realpath_sync(&path)?))
}
Some(path) => canonicalize_path_maybe_not_exists_with_fs(&path, |path| {
self
.fs
.realpath_sync(path)
.map_err(|err| err.into_io_error())
})
.map_err(|err| err.into()),
None => bail!("could not find npm package for '{}'", specifier),
}
}