language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-15 15:15:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Exit HandleScope before snapshotting (#4168)

Browse source 
The V8 documentation explicitly states that SnapshotCreator::CreateBlob()
should not be called from within a HandleScope.

Additionally, this patch removes some non-functional error handling code
from the deno_core::Isolate::snapshot() method.
This commit is contained in:
Bert Belder 2020-02-27 23:28:33 -08:00
parent 9075daa2e3
commit bc7dbfafff
No known key found for this signature in database
GPG key ID: 7A77887B2E2ED461
2 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
deno_typescript/lib.rs
View file

@ -232,7 +232,7 @@ fn write_snapshot(
snapshot_filename: &Path,
) -> Result<(), ErrBox> {
println!("Creating snapshot...");
let snapshot = runtime_isolate.snapshot()?;
let snapshot = runtime_isolate.snapshot();
let snapshot_slice: &[u8] = &*snapshot;
println!("Snapshot size: {}", snapshot_slice.len());
fs::write(&snapshot_filename, snapshot_slice)?;