clean up textproto code in std (#4458)

- moved and renamed append() into bytes from ws and textproto
- renamed textproto/readder_tests.ts -> textproto/test.ts

std/textproto/test.ts

@@ -1,17 +1,180 @@
-// Based on https://github.com/golang/go/blob/891682/src/net/textproto/
+// Based on https://github.com/golang/go/blob/master/src/net/textproto/reader_test.go
 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-import { append } from "./mod.ts";
-import { assertEquals } from "../testing/asserts.ts";
+import { BufReader } from "../io/bufio.ts";
+import { TextProtoReader } from "./mod.ts";
+import { stringsReader } from "../io/util.ts";
+import {
+  assert,
+  assertEquals,
+  assertThrows,
+  assertNotEOF
+} from "../testing/asserts.ts";
 const { test } = Deno;
 
-test(function textprotoAppend(): void {
-  const enc = new TextEncoder();
-  const dec = new TextDecoder();
-  const u1 = enc.encode("Hello ");
-  const u2 = enc.encode("World");
-  const joined = append(u1, u2);
-  assertEquals(dec.decode(joined), "Hello World");
+function reader(s: string): TextProtoReader {
+  return new TextProtoReader(new BufReader(stringsReader(s)));
+}
+
+test({
+  ignore: true,
+  name: "[textproto] Reader : DotBytes",
+  fn(): Promise<void> {
+    const _input =
+      "dotlines\r\n.foo\r\n..bar\n...baz\nquux\r\n\r\n.\r\nanot.her\r\n";
+    return Promise.resolve();
+  }
+});
+
+test("[textproto] ReadEmpty", async () => {
+  const r = reader("");
+  const m = await r.readMIMEHeader();
+  assertEquals(m, Deno.EOF);
+});
+
+test("[textproto] Reader", async () => {
+  const r = reader("line1\nline2\n");
+  let s = await r.readLine();
+  assertEquals(s, "line1");
+
+  s = await r.readLine();
+  assertEquals(s, "line2");
+
+  s = await r.readLine();
+  assert(s === Deno.EOF);
+});
+
+test({
+  name: "[textproto] Reader : MIME Header",
+  async fn(): Promise<void> {
+    const input =
+      "my-key: Value 1  \r\nLong-key: Even Longer Value\r\nmy-Key: " +
+      "Value 2\r\n\n";
+    const r = reader(input);
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("My-Key"), "Value 1, Value 2");
+    assertEquals(m.get("Long-key"), "Even Longer Value");
+  }
+});
+
+test({
+  name: "[textproto] Reader : MIME Header Single",
+  async fn(): Promise<void> {
+    const input = "Foo: bar\n\n";
+    const r = reader(input);
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("Foo"), "bar");
+  }
+});
+
+test({
+  name: "[textproto] Reader : MIME Header No Key",
+  async fn(): Promise<void> {
+    const input = ": bar\ntest-1: 1\n\n";
+    const r = reader(input);
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("Test-1"), "1");
+  }
+});
+
+test({
+  name: "[textproto] Reader : Large MIME Header",
+  async fn(): Promise<void> {
+    const data: string[] = [];
+    // Go test is 16*1024. But seems it can't handle more
+    for (let i = 0; i < 1024; i++) {
+      data.push("x");
+    }
+    const sdata = data.join("");
+    const r = reader(`Cookie: ${sdata}\r\n\r\n`);
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("Cookie"), sdata);
+  }
+});
+
+// Test that we read slightly-bogus MIME headers seen in the wild,
+// with spaces before colons, and spaces in keys.
+test({
+  name: "[textproto] Reader : MIME Header Non compliant",
+  async fn(): Promise<void> {
+    const input =
+      "Foo: bar\r\n" +
+      "Content-Language: en\r\n" +
+      "SID : 0\r\n" +
+      "Audio Mode : None\r\n" +
+      "Privilege : 127\r\n\r\n";
+    const r = reader(input);
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("Foo"), "bar");
+    assertEquals(m.get("Content-Language"), "en");
+    assertEquals(m.get("SID"), "0");
+    assertEquals(m.get("Privilege"), "127");
+    // Not a legal http header
+    assertThrows((): void => {
+      assertEquals(m.get("Audio Mode"), "None");
+    });
+  }
+});
+
+test({
+  name: "[textproto] Reader : MIME Header Malformed",
+  async fn(): Promise<void> {
+    const input = [
+      "No colon first line\r\nFoo: foo\r\n\r\n",
+      " No colon first line with leading space\r\nFoo: foo\r\n\r\n",
+      "\tNo colon first line with leading tab\r\nFoo: foo\r\n\r\n",
+      " First: line with leading space\r\nFoo: foo\r\n\r\n",
+      "\tFirst: line with leading tab\r\nFoo: foo\r\n\r\n",
+      "Foo: foo\r\nNo colon second line\r\n\r\n"
+    ];
+    const r = reader(input.join(""));
+
+    let err;
+    try {
+      await r.readMIMEHeader();
+    } catch (e) {
+      err = e;
+    }
+    assert(err instanceof Deno.errors.InvalidData);
+  }
+});
+
+test({
+  name: "[textproto] Reader : MIME Header Trim Continued",
+  async fn(): Promise<void> {
+    const input =
+      "" + // for code formatting purpose.
+      "a:\n" +
+      " 0 \r\n" +
+      "b:1 \t\r\n" +
+      "c: 2\r\n" +
+      " 3\t\n" +
+      "  \t 4  \r\n\n";
+    const r = reader(input);
+    let err;
+    try {
+      await r.readMIMEHeader();
+    } catch (e) {
+      err = e;
+    }
+    assert(err instanceof Deno.errors.InvalidData);
+  }
+});
+
+test({
+  name: "[textproto] #409 issue : multipart form boundary",
+  async fn(): Promise<void> {
+    const input = [
+      "Accept: */*\r\n",
+      'Content-Disposition: form-data; name="test"\r\n',
+      " \r\n",
+      "------WebKitFormBoundaryimeZ2Le9LjohiUiG--\r\n\n"
+    ];
+    const r = reader(input.join(""));
+    const m = assertNotEOF(await r.readMIMEHeader());
+    assertEquals(m.get("Accept"), "*/*");
+    assertEquals(m.get("Content-Disposition"), 'form-data; name="test"');
+  }
 });