fix(publish): error for missing version constraints on dry-publish instead of just publish (#23798)

Closes https://github.com/denoland/deno/issues/22835

tests/specs/jsr/no_unused_params/main.ts

@@ -1,4 +1,4 @@
-import * as inner from "jsr:@denotest/add";
+import * as inner from "jsr:@denotest/add@1";
 
 export function add(a: number, b: number): number {
   return inner.add(a, b);

tests/specs/publish/missing_constraint/__test__.jsonc

@@ -0,0 +1,5 @@
+{
+  "args": "publish --dry-run",
+  "output": "publish.out",
+  "exitCode": 1
+}

tests/specs/publish/missing_constraint/deno.json

@@ -0,0 +1,9 @@
+{
+  "name": "@scope/pkg",
+  "version": "1.0.0",
+  "exports": "./mod.ts",
+  "imports": {
+    "basic": "npm:@denotest/esm-basic",
+    "add": "jsr:@denotest/add"
+  }
+}

tests/specs/publish/missing_constraint/mod.ts

@@ -0,0 +1,7 @@
+import { add } from "add";
+import * as basic from "basic";
+import * as deps from "jsr:@denotest/deps";
+
+console.log(add(1, 2));
+console.log(deps);
+console.log(basic);

tests/specs/publish/missing_constraint/publish.out

@@ -0,0 +1,37 @@
+[WILDCARD]
+Checking for slow types in the public API...
+Check file:///[WILDLINE]/mod.ts
+error[missing-constraint]: specifier 'jsr:@denotest/add' is missing a version constraint
+ --> [WILDLINE]mod.ts:[WILDLINE]
+  | 
+1 | import { add } from "add";
+  |                     ^^^^^ the specifier
+  = hint: specify a version constraint for the specifier in the import map
+
+  info: the specifier resolved to version 1.0.0 today, but will resolve to a different
+  info: major version if one is published in the future and potentially break
+  docs: https://jsr.io/go/missing-constraint
+
+error[missing-constraint]: specifier 'npm:@denotest/esm-basic' is missing a version constraint
+ --> [WILDLINE]mod.ts:[WILDLINE]
+  | 
+2 | import * as basic from "basic";
+  |                        ^^^^^^^ the specifier
+  = hint: specify a version constraint for the specifier in the import map
+
+  info: the specifier resolved to version 1.0.0 today, but will resolve to a different
+  info: major version if one is published in the future and potentially break
+  docs: https://jsr.io/go/missing-constraint
+
+error[missing-constraint]: specifier 'jsr:@denotest/deps' is missing a version constraint
+ --> [WILDLINE]mod.ts:[WILDLINE]
+  | 
+3 | import * as deps from "jsr:@denotest/deps";
+  |                       ^^^^^^^^^^^^^^^^^^^^ the specifier
+  = hint: specify a version constraint for the specifier
+
+  info: the specifier resolved to version 1.0.0 today, but will resolve to a different
+  info: major version if one is published in the future and potentially break
+  docs: https://jsr.io/go/missing-constraint
+
+error: Found 3 problems

tests/specs/publish/missing_constraint_jsx_import_source/__test__.jsonc

@@ -0,0 +1,5 @@
+{
+  "args": "publish --token 'sadfasdf'",
+  "output": "mod.out",
+  "exitCode": 1
+}

tests/specs/publish/missing_constraint_jsx_import_source/foo.tsx

@@ -0,0 +1,5 @@
+import { renderToString } from "npm:preact-render-to-string@6";
+
+export default function render() {
+  return renderToString(<div>foo.tsx</div>);
+}

tests/specs/publish/missing_constraint_jsx_import_source/jsr.jsonc

@@ -0,0 +1,11 @@
+{
+  "name": "@foo/bar",
+  "version": "1.0.0",
+  "exports": {
+    ".": "./mod.ts"
+  },
+  "compilerOptions": {
+    "jsx": "react-jsx",
+    "jsxImportSource": "npm:preact"
+  }
+}

tests/specs/publish/missing_constraint_jsx_import_source/mod.out

@@ -0,0 +1,17 @@
+[WILDCARD]
+Checking for slow types in the public API...
+Check file:///[WILDCARD]/mod.ts
+error[missing-constraint]: specifier 'npm:preact/jsx-runtime' is missing a version constraint
+ --> [WILDLINE]
+  = hint: specify a version constraint for the specifier
+
+  info: the specifier resolved to version 10.19.6 today, but will resolve to a different
+  info: major version if one is published in the future and potentially break
+  docs: https://jsr.io/go/missing-constraint
+
+warning[unsupported-jsx-tsx]: JSX and TSX files are currently not supported
+ --> [WILDLINE]foo.tsx
+
+  info: follow https://github.com/jsr-io/jsr/issues/24 for updates
+
+error: Found 1 problem

tests/specs/publish/missing_constraint_jsx_import_source/mod.ts

@@ -0,0 +1,5 @@
+import fooTsx from "./foo.tsx";
+
+export function renderTsx() {
+  console.log(fooTsx());
+}

tests/specs/publish/package_json/package.json

@@ -2,6 +2,6 @@
   "name": "@deno/foo",
   "version": "0.0.1",
   "dependencies": {
-    "picocolors": "*"
+    "picocolors": "1"
   }
 }

tests/specs/publish/unsupported_jsx_tsx/foo.jsx

@@ -1,4 +1,4 @@
-import { renderToString } from "npm:preact-render-to-string";
+import { renderToString } from "npm:preact-render-to-string@6";
 
 export default function render() {
   return renderToString(<div>foo.tsx</div>);

tests/specs/publish/unsupported_jsx_tsx/foo.tsx

@@ -1,4 +1,4 @@
-import { renderToString } from "npm:preact-render-to-string";
+import { renderToString } from "npm:preact-render-to-string@6";
 
 export default function render() {
   return renderToString(<div>foo.tsx</div>);

tests/specs/publish/unsupported_jsx_tsx/jsr.jsonc

@@ -6,6 +6,6 @@
   },
   "compilerOptions": {
     "jsx": "react-jsx",
-    "jsxImportSource": "npm:preact"
+    "jsxImportSource": "npm:preact@10"
   }
 }