language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 02:48:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

chore(ext/node): revert changes to ClientRequest.onSocket (#19426)

Browse source 
Partially reverts https://github.com/denoland/deno/pull/19340
because it causes hangs in some situations.
This commit is contained in:
Bartek Iwańczuk 2023-06-08 20:32:26 +02:00 • committed by GitHub
parent 1d4c66308c
commit c775001466
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cli/tests/unit_node/http_test.ts
View file

@ -195,14 +195,11 @@ Deno.test("[node/http] request default protocol", async () => {
// @ts-ignore IncomingMessageForClient
// deno-lint-ignore no-explicit-any
let clientRes: any;
// deno-lint-ignore no-explicit-any
let clientReq: any;
server.listen(() => {
clientReq = http.request(
const req = http.request(
// deno-lint-ignore no-explicit-any
{ host: "localhost", port: (server.address() as any).port },
(res) => {
assert(res.socket instanceof EventEmitter);
assertEquals(res.complete, false);
res.on("data", () => {});
res.on("end", () => {
@ -213,14 +210,13 @@ Deno.test("[node/http] request default protocol", async () => {
promise2.resolve();
},
);
clientReq.end();
req.end();
});
server.on("close", () => {
promise.resolve();
});
await promise;
await promise2;
assert(clientReq.socket instanceof EventEmitter);
assertEquals(clientRes!.complete, true);
});