feat: Deno namespace configurable and unfrozen (#11062)

Closes #11033

cli/tests/unit/globals_test.ts

@@ -62,8 +62,8 @@ unitTest(function DenoNamespaceEqualsWindowDeno(): void {
   assert(Deno === window.Deno);
 });
 
-unitTest(function DenoNamespaceIsFrozen(): void {
+unitTest(function DenoNamespaceIsNotFrozen(): void {
-  assert(Object.isFrozen(Deno));
+  assert(!Object.isFrozen(Deno));
 });
 
 unitTest(function webAssemblyExists(): void {
@@ -77,46 +77,14 @@ declare global {
   }
 }
 
-unitTest(function DenoNamespaceImmutable(): void {
+unitTest(function DenoNamespaceConfigurable() {
-  const denoCopy = window.Deno;
+  const desc = Object.getOwnPropertyDescriptor(globalThis, "Deno");
-  try {
+  assert(desc);
-    // deno-lint-ignore no-explicit-any
+  assert(desc.configurable);
-    (Deno as any) = 1;
+  assert(!desc.writable);
-  } catch {
+});
-    // pass
-  }
-  assert(denoCopy === Deno);
-  try {
-    // deno-lint-ignore no-explicit-any
-    (window as any).Deno = 1;
-  } catch {
-    // pass
-  }
-  assert(denoCopy === Deno);
-  try {
-    // deno-lint-ignore no-explicit-any
-    delete (window as any).Deno;
-  } catch {
-    // pass
-  }
-  assert(denoCopy === Deno);
-
-  const { readFile } = Deno;
-  try {
-    // deno-lint-ignore no-explicit-any
-    (Deno as any).readFile = 1;
-  } catch {
-    // pass
-  }
-  assert(readFile === Deno.readFile);
-  try {
-    // deno-lint-ignore no-explicit-any
-    delete (window as any).Deno.readFile;
-  } catch {
-    // pass
-  }
-  assert(readFile === Deno.readFile);
 
+unitTest(function DenoCoreNamespaceIsImmutable(): void {
   const { print } = Deno.core;
   try {
     Deno.core.print = 1;

runtime/js/06_util.js

@@ -117,6 +117,7 @@
     return {
       value,
       writable: true,
+      enumerable: false,
       configurable: true,
     };
   }
@@ -125,6 +126,8 @@
     return {
       value,
       enumerable: true,
+      writable: false,
+      configurable: true,
     };
   }
 
@@ -132,6 +135,7 @@
     return {
       get: getter,
       enumerable: true,
+      configurable: true,
     };
   }
 

runtime/js/99_main.js

@@ -492,10 +492,9 @@ delete Object.prototype.__proto__;
       Object.assign(finalDenoNs, denoNsUnstable);
     }
 
-    // Setup `Deno` global - we're actually overriding already
+    // Setup `Deno` global - we're actually overriding already existing global
-    // existing global `Deno` with `Deno` namespace from "./deno.ts".
+    // `Deno` with `Deno` namespace from "./deno.ts".
-    util.immutableDefine(globalThis, "Deno", finalDenoNs);
+    Object.defineProperty(globalThis, "Deno", util.readOnly(finalDenoNs));
-    Object.freeze(globalThis.Deno);
     Object.freeze(globalThis.Deno.core);
     Object.freeze(globalThis.Deno.core.sharedQueue);
     signals.setSignals();