language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 10:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: permission stack traces in ops (#26938)

Browse source 
This commit improves permission prompts by adding an option
to print a full trace of where the permissions is being requested.

Due to big performance hint of stack trace collection, this is only
enabled when `DENO_TRACE_PERMISSIONS` env var is present.

Closes https://github.com/denoland/deno/issues/20756

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
This commit is contained in:
Leo Kettmeir 2024-11-20 13:24:04 -08:00 • committed by GitHub
parent 8f72798622
commit cf49599359
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
34 changed files with 294 additions and 181 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ext/websocket/lib.rs
View file

@ -148,7 +148,7 @@ impl Resource for WsCancelResource {
// This op is needed because creating a WS instance in JavaScript is a sync
// operation and should throw error when permissions are not fulfilled,
// but actual op that connects WS is async.
#[op2]
#[op2(stack_trace)]
#[smi]
pub fn op_ws_check_permission_and_cancel_handle<WP>(
state: &mut OpState,
@ -443,7 +443,7 @@ fn populate_common_request_headers(
Ok(request)
}
#[op2(async)]
#[op2(async, stack_trace)]
#[serde]
pub async fn op_ws_create<WP>(
state: Rc<RefCell<OpState>>,