language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 18:38:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(ts): remove op_cache (#5071)

Browse source 
This PR removes op_cache and refactors how Deno interacts with TS compiler.

Ultimate goal is to completely sandbox TS compiler worker; it should operate on
simple request -> response basis. With this commit TS compiler no longer
caches compiled sources as they are generated but rather collects all sources
and sends them back to Rust when compilation is done.

Additionally "Diagnostic" and its children got refactored to use "Deserialize" trait
instead of manually implementing JSON deserialization.
This commit is contained in:
Bartek Iwańczuk 2020-05-05 18:23:15 +02:00 • committed by GitHub
parent e574437922
commit cf5a39a361
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 348 additions and 503 deletions
Download patch file Download diff file Expand all files Collapse all files

7
cli/ops/errors.rs
View file

@ -57,9 +57,6 @@ fn op_format_diagnostic(
args: Value,
_zero_copy: Option<ZeroCopyBuf>,
) -> Result<JsonOp, OpError> {
if let Some(diagnostic) = Diagnostic::from_json_value(&args) {
Ok(JsonOp::Sync(json!(diagnostic.to_string())))
} else {
Err(OpError::type_error("bad diagnostic".to_string()))
}
let diagnostic = serde_json::from_value::<Diagnostic>(args)?;
Ok(JsonOp::Sync(json!(diagnostic.to_string())))
}