language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-29 13:44:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: clearing timers race condition (#7617)

Browse source
This commit is contained in:
Bartek Iwańczuk 2020-09-22 19:33:29 +02:00 • committed by GitHub
parent a43984c9cf
commit dd1cd4d952
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 79 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

11
cli/rt/11_timers.js
View file

@ -8,8 +8,12 @@
core.jsonOpSync("op_global_timer_stop");
}
async function opStartGlobalTimer(timeout) {
await core.jsonOpAsync("op_global_timer", { timeout });
function opStartGlobalTimer(timeout) {
return core.jsonOpSync("op_global_timer_start", { timeout });
}
async function opWaitGlobalTimer() {
await core.jsonOpAsync("op_global_timer");
}
function opNow() {
@ -314,7 +318,8 @@
// some timeout/defer is put in place to allow promise resolution.
// Ideally `clearGlobalTimeout` doesn't return until this op is resolved, but
// I'm not if that's possible.
await opStartGlobalTimer(timeout);
opStartGlobalTimer(timeout);
await opWaitGlobalTimer();
pendingEvents--;
// eslint-disable-next-line @typescript-eslint/no-use-before-define
prepareReadyTimers();