language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 19:08:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(serde_v8): split ZeroCopyBuf into JsBuffer and ToJsBuffer (#19566)

Browse source 
`ZeroCopyBuf` was convenient to use, but sometimes it did hide details
that some copies were necessary in certain cases. Also it made it way to easy
for the caller to pass around and convert into different values. This commit
splits `ZeroCopyBuf` into `JsBuffer` (an array buffer coming from V8) and
`ToJsBuffer` (a Rust buffer that will be converted into a V8 array buffer).

As a result some magical conversions were removed (they were never used)
limiting the API surface and preparing for changes in #19534.
This commit is contained in:
Bartek Iwańczuk 2023-06-22 23:37:56 +02:00 • committed by GitHub
parent b319fa7f49
commit dda0f1c343
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
39 changed files with 353 additions and 382 deletions
Download patch file Download diff file Expand all files Collapse all files

4
runtime/ops/http.rs
View file

@ -11,7 +11,7 @@ use deno_core::op;
use deno_core::OpState;
use deno_core::RcRef;
use deno_core::ResourceId;
use deno_core::ZeroCopyBuf;
use deno_core::ToJsBuffer;
use deno_http::http_create_conn_resource;
use deno_http::HttpRequestReader;
use deno_http::HttpStreamResource;
@ -93,7 +93,7 @@ fn op_http_start(
pub struct HttpUpgradeResult {
conn_rid: ResourceId,
conn_type: &'static str,
read_buf: ZeroCopyBuf,
read_buf: ToJsBuffer,
}
#[op]

6
runtime/ops/process.rs
View file

@ -12,7 +12,7 @@ use deno_core::OpState;
use deno_core::RcRef;
use deno_core::Resource;
use deno_core::ResourceId;
use deno_core::ZeroCopyBuf;
use deno_core::ToJsBuffer;
use deno_io::fs::FileResource;
use deno_io::ChildStderrResource;
use deno_io::ChildStdinResource;
@ -198,8 +198,8 @@ impl TryFrom<ExitStatus> for ChildStatus {
#[serde(rename_all = "camelCase")]
pub struct SpawnOutput {
status: ChildStatus,
stdout: Option<ZeroCopyBuf>,
stderr: Option<ZeroCopyBuf>,
stdout: Option<ToJsBuffer>,
stderr: Option<ToJsBuffer>,
}
fn create_command(