language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-03 18:38:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

perf(ext/websocket): Make send sync for non-stream websockets (#19376)

Browse source 
No need to go through the async machinery for `send(String | Buffer)` --
we can fire and forget, and then route any send errors into the async
call we're already making (`op_ws_next_event`).

Early benchmark on MacOS:

Before: 155.8k msg/sec
After: 166.2k msg/sec (+6.6%)

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
This commit is contained in:
Matt Mastracci 2023-06-06 07:58:18 -06:00 • committed by GitHub
parent 42991017e9
commit df76a062fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 93 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ext/websocket/02_websocketstream.js
View file

@ -34,8 +34,8 @@ const {
Uint8ArrayPrototype,
} = primordials;
const {
op_ws_send_text,
op_ws_send_binary,
op_ws_send_text_async,
op_ws_send_binary_async,
op_ws_next_event,
op_ws_create,
op_ws_close,
@ -210,11 +210,11 @@ class WebSocketStream {
const writable = new WritableStream({
write: async (chunk) => {
if (typeof chunk === "string") {
await op_ws_send_text(this[_rid], chunk);
await op_ws_send_text_async(this[_rid], chunk);
} else if (
ObjectPrototypeIsPrototypeOf(Uint8ArrayPrototype, chunk)
) {
await op_ws_send_binary(this[_rid], chunk);
await op_ws_send_binary_async(this[_rid], chunk);
} else {
throw new TypeError(
"A chunk may only be either a string or an Uint8Array",