language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 19:08:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor(cli): fewer clones (#17450)

Browse source
This commit is contained in:
Geert-Jan Zwiers 2023-01-16 21:27:41 +01:00 • committed by GitHub
parent 40527526e5
commit e023a6e3f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 21 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cli/lsp/analysis.rs
View file

@ -29,12 +29,7 @@ use tower_lsp::lsp_types::Range;
/// Diagnostic error codes which actually are the same, and so when grouping
/// fixes we treat them the same.
static FIX_ALL_ERROR_CODES: Lazy<HashMap<&'static str, &'static str>> =
Lazy::new(|| {
([("2339", "2339"), ("2345", "2339")])
.iter()
.cloned()
.collect()
});
Lazy::new(|| ([("2339", "2339"), ("2345", "2339")]).into_iter().collect());
/// Fixes which help determine if there is a preferred fix when there are
/// multiple fixes available.
@ -54,8 +49,7 @@ static PREFERRED_FIXES: Lazy<HashMap<&'static str, (u32, bool)>> =
("addMissingAwait", (1, false)),
("fixImport", (0, true)),
])
.iter()
.cloned()
.into_iter()
.collect()
});

8
cli/lsp/diagnostics.rs
View file

@ -525,12 +525,10 @@ async fn generate_ts_diagnostics(
let specifiers = snapshot
.documents
.documents(true, true)
.iter()
.map(|d| d.specifier().clone())
.collect::<Vec<_>>();
.into_iter()
.map(|d| d.specifier().clone());
let (enabled_specifiers, disabled_specifiers) = specifiers
.iter()
.cloned()
.into_iter()
.partition::<Vec<_>, _>(|s| config.specifier_enabled(s));
let ts_diagnostics_map: TsDiagnosticsMap = if !enabled_specifiers.is_empty() {
let req = tsc::RequestMethod::GetDiagnostics(enabled_specifiers);

12
cli/lsp/documents.rs
View file

@ -52,15 +52,13 @@ static JS_HEADERS: Lazy<HashMap<String, String>> = Lazy::new(|| {
"content-type".to_string(),
"application/javascript".to_string(),
)])
.iter()
.cloned()
.into_iter()
.collect()
});
static JSX_HEADERS: Lazy<HashMap<String, String>> = Lazy::new(|| {
([("content-type".to_string(), "text/jsx".to_string())])
.iter()
.cloned()
.into_iter()
.collect()
});
@ -69,15 +67,13 @@ static TS_HEADERS: Lazy<HashMap<String, String>> = Lazy::new(|| {
"content-type".to_string(),
"application/typescript".to_string(),
)])
.iter()
.cloned()
.into_iter()
.collect()
});
static TSX_HEADERS: Lazy<HashMap<String, String>> = Lazy::new(|| {
([("content-type".to_string(), "text/tsx".to_string())])
.iter()
.cloned()
.into_iter()
.collect()
});