language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-10-01 06:31:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix(install): cache json exports of JSR packages (#26552)

Browse source 
Fixes https://github.com/denoland/deno/issues/26509.

Ended up being a `deno_graph` bug causing the error to surface. This PR
updates `deno_graph` to pick up the fix and reverts the temporary
workaround that skipped JSON exports.
This commit is contained in:
Nathan Whitaker 2024-10-25 13:19:03 -07:00 • committed by GitHub
parent a01edb394d
commit ec968aa5ae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 39 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
cli/Cargo.toml
View file

@ -73,7 +73,7 @@ deno_cache_dir = { workspace = true }
deno_config = { version = "=0.37.2", features = ["workspace", "sync"] }
deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_doc = { version = "0.154.0", default-features = false, features = ["rust", "html", "syntect"] }
deno_graph = { version = "=0.83.3" }
deno_graph = { version = "=0.83.4" }
deno_lint = { version = "=0.67.0", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm.workspace = true

7
cli/tools/registry/pm/cache_deps.rs
View file

@ -90,13 +90,8 @@ pub async fn cache_top_level_deps(
while let Some(info_future) = info_futures.next().await {
if let Some((specifier, info)) = info_future {
let exports = info.exports();
for (k, v) in exports {
for (k, _) in exports {
if let Ok(spec) = specifier.join(k) {
if v.ends_with(".json") {
// TODO(nathanwhit): this should work, there's a bug with
// json roots in deno_graph. skip it for now
continue;
}
roots.push(spec);
}
}