language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-07-25 06:04:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(fetch): proxy body for requests created from other requests (#11093)

Browse source 
Additionally, if the existing `Request`'s body is disturbed, the Request creation
should fail.

This change also updates the step numbers in the Request constructor to match
whatwg/fetch#1249.
This commit is contained in:
Andreu Botella 2021-06-23 16:00:23 +02:00 • committed by GitHub
parent 2c4ce26f0b
commit edab21ebab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 45 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

30
extensions/fetch/23_request.js
View file

@ -257,14 +257,16 @@
// 28.
this[_signal] = abortSignal.newSignal();
// 29.
if (signal !== null) {
abortSignal.follow(this[_signal], signal);
}
// 29.
// 30.
this[_headers] = headersFromHeaderList(request.headerList, "request");
// 31.
// 32.
if (Object.keys(init).length > 0) {
let headers = headerListFromHeaders(this[_headers]).slice(
0,
@ -280,13 +282,13 @@
fillHeaders(this[_headers], headers);
}
// 32.
// 33.
let inputBody = null;
if (input instanceof Request) {
inputBody = input[_body];
}
// 33.
// 34.
if (
(request.method === "GET" || request.method === "HEAD") &&
((init.body !== undefined && init.body !== null) ||
@ -295,10 +297,10 @@
throw new TypeError("Request with GET/HEAD method cannot have body.");
}
// 34.
// 35.
let initBody = null;
// 35.
// 36.
if (init.body !== undefined && init.body !== null) {
const res = extractBody(init.body);
initBody = res.body;
@ -307,20 +309,22 @@
}
}
// 36.
// 37.
const inputOrInitBody = initBody ?? inputBody;
// 38.
const finalBody = inputOrInitBody;
// 39.
// TODO(lucacasonato): implement this step. Is it needed?
let finalBody = inputOrInitBody;
// 40.
request.body = finalBody;
if (initBody === null && inputBody !== null) {
if (input[_body] && input[_body].unusable()) {
throw new TypeError("Input request's body is unusable.");
}
finalBody = inputBody.createProxy();
}
// 41.
// TODO(lucacasonato): Extranious? https://github.com/whatwg/fetch/issues/1249
request.body = finalBody;
}
get method() {