language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-09-26 20:29:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: Stabilize Deno.TcpConn.setNoDelay() and Deno.TcpConn.setKeepAlive() (#17003)

Browse source 
This commit stabilizes following APIs:
- `Deno.TcpConn.setNoDelay()`
- `Deno.TcpConn.setKeepAlive()`
This commit is contained in:
Bartek Iwańczuk 2022-12-14 00:54:11 +01:00 • committed by GitHub
parent 392cca87a8
commit f9db129bdf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ext/net/01_net.js
View file

@ -100,12 +100,12 @@
} }
class TcpConn extends Conn { class TcpConn extends Conn {
setNoDelay(nodelay = true) { setNoDelay(noDelay = true) {
return ops.op_set_nodelay(this.rid, nodelay); return ops.op_set_nodelay(this.rid, noDelay);
} }
setKeepAlive(keepalive = true) { setKeepAlive(keepAlive = true) {
return ops.op_set_keepalive(this.rid, keepalive); return ops.op_set_keepalive(this.rid, keepAlive);
} }
} }

14
ext/net/lib.deno_net.d.ts vendored
View file

@ -185,19 +185,13 @@ declare namespace Deno {
/** @category Network */ /** @category Network */
export interface TcpConn extends Conn { export interface TcpConn extends Conn {
/** /**
* **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617.
*
* Enable/disable the use of Nagle's algorithm. * Enable/disable the use of Nagle's algorithm.
* *
* @param [nodelay=true] * @param [noDelay=true]
*/ */
setNoDelay(nodelay?: boolean): void; setNoDelay(noDelay?: boolean): void;
/** /** Enable/disable keep-alive functionality. */
* **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617. setKeepAlive(keepAlive?: boolean): void;
*
* Enable/disable keep-alive functionality.
*/
setKeepAlive(keepalive?: boolean): void;
} }
/** @category Network */ /** @category Network */

2
ext/net/ops.rs
View file

@ -514,7 +514,6 @@ pub fn op_set_nodelay(
rid: ResourceId, rid: ResourceId,
nodelay: bool, nodelay: bool,
) -> Result<(), AnyError> { ) -> Result<(), AnyError> {
super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> = let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?; state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_nodelay(nodelay) resource.set_nodelay(nodelay)
@ -526,7 +525,6 @@ pub fn op_set_keepalive(
rid: ResourceId, rid: ResourceId,
keepalive: bool, keepalive: bool,
) -> Result<(), AnyError> { ) -> Result<(), AnyError> {
super::check_unstable(state, "Deno.Conn#setKeepAlive");
let resource: Rc<TcpStreamResource> = let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?; state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_keepalive(keepalive) resource.set_keepalive(keepalive)

1
ops/optimizer_tests/unit_result2.out
View file

@ -36,7 +36,6 @@ impl op_set_nodelay {
rid: ResourceId, rid: ResourceId,
nodelay: bool, nodelay: bool,
) -> Result<(), AnyError> { ) -> Result<(), AnyError> {
super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> = state let resource: Rc<TcpStreamResource> = state
.resource_table .resource_table
.get::<TcpStreamResource>(rid)?; .get::<TcpStreamResource>(rid)?;

1
ops/optimizer_tests/unit_result2.rs
View file

@ -3,7 +3,6 @@ pub fn op_set_nodelay(
rid: ResourceId, rid: ResourceId,
nodelay: bool, nodelay: bool,
) -> Result<(), AnyError> { ) -> Result<(), AnyError> {
super::check_unstable(state, "Deno.Conn#setNoDelay");
let resource: Rc<TcpStreamResource> = let resource: Rc<TcpStreamResource> =
state.resource_table.get::<TcpStreamResource>(rid)?; state.resource_table.get::<TcpStreamResource>(rid)?;
resource.set_nodelay(nodelay) resource.set_nodelay(nodelay)