language-servers/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-08-04 10:59:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(unstable): don't error on non-existing attrs or type attr (#27456)

Browse source 
When running selectors for JS linting plugins we would error when
encountering an unknown attribute name:

```js
// selector
Foo[non-existant]

// error
Error: Missing string id: <number>
```

This was caused by using `0` as the invalid marker, but also overloading
`0` with an actual node type. So the fix is to reserve `0` as the
invalid marker and move the property type to the next index.
This commit is contained in:
Marvin Hagemeister 2024-12-27 22:46:29 +01:00 • committed by GitHub
parent c45d0dadb3
commit fdd0edf23c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 65 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

41
cli/js/40_lint.js
View file

@ -15,10 +15,10 @@ const {
// Keep in sync with Rust
// These types are expected to be present on every node. Note that this
// isn't set in stone. We could revise this at a future point.
const AST_PROP_TYPE = 0;
const AST_PROP_PARENT = 1;
const AST_PROP_RANGE = 2;
const AST_PROP_LENGTH = 3;
const AST_PROP_TYPE = 1;
const AST_PROP_PARENT = 2;
const AST_PROP_RANGE = 3;
const AST_PROP_LENGTH = 4;
// Keep in sync with Rust
// Each node property is tagged with this enum to denote
@ -421,10 +421,12 @@ class MatchCtx {
/**
* @param {AstContext["buf"]} buf
* @param {AstContext["strTable"]} strTable
* @param {AstContext["strByType"]} strByType
*/
constructor(buf, strTable) {
constructor(buf, strTable, strByType) {
this.buf = buf;
this.strTable = strTable;
this.strByType = strByType;
}
/**
@ -452,7 +454,19 @@ class MatchCtx {
getAttrPathValue(offset, propIds, idx) {
const { buf } = this;
offset = findPropOffset(buf, offset, propIds[idx]);
const propId = propIds[idx];
switch (propId) {
case AST_PROP_TYPE: {
const type = this.getType(offset);
return getString(this.strTable, this.strByType[type]);
}
case AST_PROP_PARENT:
case AST_PROP_RANGE:
throw new Error(`Not supported`);
}
offset = findPropOffset(buf, offset, propId);
if (offset === -1) return undefined;
const _prop = buf[offset++];
const kind = buf[offset++];
@ -499,7 +513,18 @@ class MatchCtx {
hasAttrPath(offset, propIds, idx) {
const { buf } = this;
offset = findPropOffset(buf, offset, propIds[idx]);
const propId = propIds[idx];
// If propId is 0 then the property doesn't exist in the AST
if (propId === 0) return false;
switch (propId) {
case AST_PROP_TYPE:
case AST_PROP_PARENT:
case AST_PROP_RANGE:
return true;
}
offset = findPropOffset(buf, offset, propId);
if (offset === -1) return false;
if (idx === propIds.length - 1) return true;
@ -736,7 +761,7 @@ function createAstContext(buf) {
strByType,
typeByStr,
propByStr,
matcher: new MatchCtx(buf, strTable),
matcher: new MatchCtx(buf, strTable, strByType),
};
setNodeGetters(ctx);