65 commits

Author	SHA1	Message	Date
Daniel Osvaldo Rahmanto	ffe207a859	fix(ext/node): FileHandle compatibility (#31164) ... Towards #29972 Tries to reland #31094 that got reverted on #31103 due to CI test failures. This PR differs by fixing the `[kUnref]` method to close resource ID correctly. Allows the following tests to pass: - https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-filehandle-close.js - https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-filehandle-use-after-close.js --------- Signed-off-by: Daniel Osvaldo Rahmanto <daniel.rahmanto@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-11-14 12:17:45 +07:00
Daniel Osvaldo Rahmanto	552cb3df05	fix(ext/node): respects flag option on fs.readfile and fs.readfilesync (#31129) ... Closes #31099	2025-10-31 09:32:36 +01:00
Daniel Osvaldo Rahmanto	202a8c054b	Revert "fix(ext/node): fileHandle compatibility" (#31103) ... Reverts denoland/deno#31094 This has caused node compat tests to fail on main.	2025-10-27 16:27:50 +00:00
Daniel Osvaldo Rahmanto	3a1ae29327	fix(ext/node): fileHandle compatibility (#31094) ... Towards #29972 Notable changes: - Omits `path` from the `FileHandle` constructor. This includes replacing `utimes` and `chown` with `futimes` and `fchown`. - Handles closing resource ID gracefully to follow node's implementation. Closed resource IDs are marked as `-1`. - Make every fs method to call the `fsCall` function. Allows the following tests to pass: - https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-filehandle-close.js - https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-filehandle-use-after-close.js	2025-10-27 16:58:23 +05:30
Daniel Osvaldo Rahmanto	2b0f277e96	fix(ext/node): fs.read/fs.readSync and fs.write/fs.writeSync compatibility (#31013) ... Towards #29972 - `fs.read` and `fs.readSync`: accepts object option parameter. - `fs.write` and `fs.writeSync`: negative position value defaults to the current seek position. - Allows several node compatibility tests to pass.	2025-10-22 10:48:42 +02:00
Daniel Osvaldo Rahmanto	a44f0cb99f	fix(ext/node): support option object parameter on fs.write and fs.writeSync (#30999) ... Closes #30972 Other changes: - Re-enables ignored tests on `tests/unit_node/_fs/_fs_write_test.ts` - Ported the polyfill to `.ts`, though defining the types are tricky since our implementation (ported from node) mutates a lot of variables.	2025-10-17 14:28:31 +02:00
Daniel Osvaldo Rahmanto	1573279c12	fix(ext/node): fs.stat and fs.statSync compatibility (#30866)	2025-10-03 11:34:01 -04:00
Daniel Osvaldo Rahmanto	dcc9474175	fix(ext/node): fs.readFile, fs.readFileSync assert encoding (#30830) ... Towards #29972 - Validates the encoding of `readFile`. - Fixes the handling of `binary` encoding where previously it returns Buffer. On Node.js, Buffer is only returned when the encoding is not specified. - Allows [parallel/test-fs-read-file-assert-encoding.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-read-file-assert-encoding.js) test to pass.	2025-09-24 15:32:41 +02:00
Daniel Osvaldo Rahmanto	ebcb2fa294	fix(ext/node): fs.statfsSync and fs.statfs compatibility (#30662) ... Towards #29972 - Converts the polyfill to typescript. - Implement async op. - Allows `Buffer` type path. - Allows [parallel/test-fs-statfs.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-statfs.js) test to pass.	2025-09-18 16:03:30 +02:00
Bartek Iwańczuk	4a1f63b930	Revert "fix(ext/node): fs.stat and fs.statSync compatibility (#30… (#30741) ... …637)" This reverts commit 432761aac5. The tests are causing flakes on Windows	2025-09-15 19:25:47 -04:00
Daniel Osvaldo Rahmanto	08d9895075	chore(test): fix node:fs.close test flakiness (#30735)	2025-09-15 17:21:22 +00:00
Daniel Osvaldo Rahmanto	432761aac5	fix(ext/node): fs.stat and fs.statSync compatibility (#30637) ... Closes #30570 Changes in this PR: - Implement `ino`, `nlink`, and `blocks` properties of `Deno.FileInfo` on Windows. These changes are automatically reflected to the corresponding node stat function. In order to do so, I had to tinker with the [createByteStruct](a3a904da14/ext/fs/30_fs.js (L297)) function to create another optional int type, apart from `?u64`. It's common for small sized files on Windows (particularly NTFS file system) to have a `Stats.blocks` property of 0, and currently all 0 values with type `?u64` will be coerced into `null` by `createByteStruct`. - Refactor the `BigIntStats` and `Stats` class, to use the same class with Node.js that are provided from [utils.mjs](7f8e488c36/ext/node/polyfills/internal/fs/utils.mjs (L577)). Also ensures that all properties are not `null` or `undefined`. - Addresses the `prefer-primordials` lint rule.	2025-09-15 15:29:30 +02:00
Daniel Osvaldo Rahmanto	6050aea25a	fix(ext/node): set default callback for fs.close (#30720) ... Fixes #30718	2025-09-15 08:05:31 +00:00
Daniel Osvaldo Rahmanto	8244cd8e21	fix(ext/node): validate readlink arguments (#30691) ... Also accepts `Buffer` typed path. Allows https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-readlink-type-check.js test to pass. Towards #29972	2025-09-11 18:43:48 +02:00
Daniel Osvaldo Rahmanto	e60f5d2c52	fix(ext/node): fs.mkdtemp and fs.mkdtempSync compatibility (#30602) ... `fs.mkdtemp` and `fs.mkdtempSync` now accept `Buffer` and `Uint8Array` path. The implementation has been moved to Rust, including directory suffix generation and directory creation.	2025-09-05 16:12:42 -04:00
Daniel Osvaldo Rahmanto	e843a115fd	fix(ext/node): fs.symlink and fs.symlinkSync compatibility (#30555)	2025-09-03 17:48:13 -04:00
Daniel Osvaldo Rahmanto	e463e57b0e	fix(ext/node): fs.exists and fs.existsSync compatibility (#30507) ... Closes #30506 Other changes: - Emit deprecation warning. - Allows [parallel/test-fs-exists.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-exists.js) to pass. - Allows [test-fs-symlink-dir-junction.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-symlink-dir-junction.js) to pass. Previously it always fail due to invalid assertion using `existsSync`.	2025-08-26 15:31:39 +02:00
Daniel Osvaldo R	e4a47febcd	fix(std/fs): implement chmod on windows (#30436) ... Closes #4357 On Windows, `chmod` can only change read and write permissions (https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/chmod-wchmod?view=msvc-170). It doesn't implement distinct permissions among group, owner, or others. Changes in this PR also enables `node:fs`’ `chmod` on Windows and fixes the `prefer-primordials` lint rule #24236.	2025-08-18 19:06:22 +02:00
Daniel Osvaldo R	55f74e809b	fix(ext/node): parse fs open options correctly (#30300) ... Fixes #30299 I decided to build the `OpenOptions` on the Rust side, because it's cheaper to pass integers to the op function and we can enable the fast op call. Also the tests that I added to the `config.toml` were already passing before this PR.	2025-08-05 11:12:22 +02:00
Daniel Osvaldo R	45f64df6c1	fix(ext/node): incorrect ERR_INVALID_ARG_VALUE constructor arguments position (#30309) ... This allows [parallel/test-fs-internal-assertencoding.js](https://github.com/nodejs/node/blob/v23.9.0/test/parallel/test-fs-internal-assertencoding.js) to pass. Towards #29972	2025-08-04 16:05:41 +00:00
Daniel Osvaldo R	8680d97b38	fix(ext/node): fs.open and fs.openSync compatibility (#30191) ... Notable changes: - Introduces a separate op between `Deno.open` and `node:fs.open`. - Removes redundant `existenceCheckRequired` and `Deno.lstatSync` calls, as the op layer already handles that when `options.create_new` is true and uses synchronous I/O when `O_SYNC` is passed. - Allows passing custom flags to the op (e.g. `O_SYNC`). - Addresses `prefer-primordials` lint rule. - Allows [parallel/test-fs-open.js](https://github.com/nodejs/node/blob/v23.9.0/test/parallel/test-fs-open.js) test to pass. There are also several tests that have passed before that I added to the config.toml.	2025-07-31 15:10:10 +00:00
Daniel Osvaldo R	af55e069ef	fix(ext/node): fs.rename and fs.renameSync compatibility (#30245)	2025-07-31 10:24:59 -04:00
Daniel Osvaldo R	d642f84203	fix(ext/node): fs.unlink and fs.unlinkSync compatibility (#30257) ... Improves compatibility with Node.js by validating the input parameters, accepting Buffer type paths, and converting thrown errors correctly. This PR also addresses `prefer-primordials` lint rule. These changes allow parallel/test-fs-unlink-type-check.js test to pass. Towards https://github.com/denoland/deno/issues/29972, https://github.com/denoland/deno/issues/24236.	2025-07-31 10:56:11 +02:00
Daniel Osvaldo R	0a01d63080	fix(ext/node): validate path parameters on link and linkSync (#30061)	2025-07-11 11:35:43 +09:00
Jeff Hykin	2f72884425	feat(node API): add fs.glob, fs.globSync, fs.promises.glob (#28972)	2025-07-01 11:35:45 +02:00
Bartek Iwańczuk	9812163db2	test: disable _fs_watch_test.ts test case (#29701) ... This test was added in https://github.com/denoland/deno/pull/29659 and an attempt to make it more stable was done in https://github.com/denoland/deno/pull/29699. Unfortunately it's still very flaky. Ignoring for now.	2025-06-11 12:51:36 +00:00
Yoshiya Hinosawa	23d19d16ef	test(ext/node): reduce flakiness of _fs_watch_test.ts (#29699)	2025-06-11 16:16:20 +09:00
ctrl+d	e27447943b	fix(ext/node): fix fs.watchFile trigger (#29659) ... Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2025-06-11 12:37:59 +09:00
Sebastien Guillemot	e2341c7949	fix(ext/node): add createReadStream & createWriteStream methods to the FileHandle class (#28700) ... Co-authored-by: Nikolay Karadzhov <nkaradzhov89@gmail.com> Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2025-04-07 17:13:32 +09:00
Divy Srivastava	52d528d21d	fix(ext/node): mkdir() parse file mode (#28609) ... Fixes https://github.com/denoland/deno/issues/28604	2025-03-25 09:33:41 +05:30
David Sherret	8971064546	feat: TypeScript 5.7 (#27857) ... Co-authored-by: Kenta Moriuchi <moriken@kimamass.com>	2025-01-31 16:07:42 -05:00
ZYSzys	4e0bf4b093	fix(ext/node): add FileHandle#sync (#27677)	2025-01-21 14:52:40 +09:00
Masato Yoshioka	b22a50cb0c	fix(ext/node): add chown method to FileHandle class (#27638)	2025-01-15 17:15:07 +09:00
siaeyy	a1f50a7422	fix(node/fs): add utimes method to the FileHandle class (#27582)	2025-01-14 18:08:22 +09:00
Aaron Ang	9cb089f6db	fix(ext/node): add writev method to FileHandle (#27563) ... Part of #25554	2025-01-14 18:01:14 +09:00
Nikolay Karadzhov	8cda4cf53d	feat(node/fs): Add a chmod method to the FileHandle class (#27522) ... Add the chmod method to the FileHandle class in node compat as part of #25554	2025-01-07 14:58:14 +01:00
Kenta Moriuchi	8fb073d7b4	chore: Happy New Year 2025 (#27509)	2024-12-31 19:12:39 +00:00
Filip Stevanovic	23f7032d56	fix(ext/node): add truncate method to the FileHandle class (#27389)	2024-12-20 13:23:51 +09:00
Filip Stevanovic	8fc4796ed5	fix(ext/node): Fix fs.access/fs.promises.access with X_OK mode parameter on Windows (#27407) ... - Fixes an issue on Windows where the `fs.constants.X_OK` flag caused `fs.access` and `fs.promises.access` to incorrectly throw a "permission denied" error - Introduced formatting changes due to the formatting tool - Fixed the issue by always removing the `X_OK` bit from the mode variable m (not sure if it's necessary to check for the presence of it in the `mode` param first?) - Updated unit tests to handle the mentioned constant - `X_OK` bit is ignored in the Node implementation and should behave like `F_OK` fs constants Node documentation: https://nodejs.org/api/fs.html#fsconstants fixes https://github.com/denoland/deno/issues/27405	2024-12-18 14:52:37 -08:00
Marvin Hagemeister	2fbc5fea83	fix(node/fs): support recursive option in readdir (#27179) ... We didn't support the `recursive` option of `fs.readdir()/fs.readdirSync()`. Fixes https://github.com/denoland/deno/issues/27175	2024-12-03 10:28:20 +01:00
Marvin Hagemeister	927352bd4e	fix(node/fs): add missing stat path argument validation (#27086) ... We didn't validate the `path` argument that's passed to `fs.stat()` and `fs.statSync()` which lead to wrong errors being thrown. The `@rollup/plugin-node-resolve` code calls it with `undefined` quite a lot which lead to `nitro` and `nuxt` failing. Fixes https://github.com/denoland/deno/issues/26700 --------- Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2024-11-27 08:35:39 +01:00
Trevor Manz	6b7e4c331b	fix(ext/node): add fs.promises.fstat and FileHandle#stat (#26719) ... Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2024-11-25 15:02:38 +09:00
Marvin Hagemeister	50538ba35d	fix(node/fs): missing uv error context for readFile (#27011) ... Dart's Node wrapper code in `npm:sass` does string slicing on the thrown error message which broke because of our missing uv error context. Code in question: ```js _systemErrorToFileSystemException0(callback) { var error, t1, exception, t2; try { t1 = callback.call$0(); return t1; } catch (exception) { error = A.unwrapException(exception); if (!type$.JsSystemError._is(error)) throw exception; t1 = error; t2 = J.getInterceptor$x(t1); throw A.wrapException(new A.FileSystemException0(J.substring$2$s(t2.get$message(t1), (A.S(t2.get$code(t1)) + ": ").length, J.get$length$asx(t2.get$message(t1)) - (", " + A.S(t2.get$syscall(t1)) + " '" + A.S(t2.get$path(t1)) + "'").length), J.get$path$x(error))); } } ``` Fixes https://github.com/denoland/deno/issues/26994	2024-11-22 22:42:27 +01:00
Łukasz Czerniawski	7becd83a38	feat(ext/fs): add ctime to Deno.stats and use it in node compat layer (#24801) ... This PR fixes #24453, by introducing a ctime (using ctime for UNIX and ChangeTime for Windows) to Deno.stats. Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2024-11-13 13:35:04 +09:00
David Sherret	af2d992ecd	feat: TypeScript 5.6 and npm:@types/node@22 (#25614)	2024-09-14 11:58:47 +01:00
Asher Gomez	a69b1e699e	BREAKING(fs): remove Deno.FsFile.prototype.rid (#25499) ... Towards #22079 --------- Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>	2024-09-11 07:19:34 +10:00
Bartek Iwańczuk	52fb6582e7	test: run node_unit_tests with DENO_FUTURE=1 (#25285) ... This is blocking https://github.com/denoland/deno/pull/25213. Turns out a bunch of FS APIs are completely broken because they use RIDs (resource IDs) instead of FDs (file descriptors).	2024-08-29 00:09:06 +00:00
David Sherret	a7c002ae63	chore: enable no-console dlint rule (#25113)	2024-08-20 15:14:37 -04:00
Nathan Whitaker	ff4226a3cd	fix(node/fs): Use correct offset and length in node:fs.read and write (#25049) ... My fix in #25030 was buggy, I forgot to pass the `byteOffset` and `byteLength`. Whoops. I also discovered that fs.read was not respecting the `offset` argument, and we were constructing a new `Buffer` for the callback instead of just passing the original one (which is what node does, and the @types/node definitions also indicate the callback should get the same type). Fixes #25028.	2024-08-16 09:48:57 -07:00
Nathan Whitaker	1f2d48cd97	fix(node/fs): node:fs.read and write should accept typed arrays other than Uint8Array (#25030) ... Part of #25028. Our underlying read/write operations in `io` assume the buffer is a Uint8Array, but we were passing in other typed arrays (in the case above it was `Int8Array`).	2024-08-14 09:42:31 -07:00