116 commits

Author	SHA1	Message	Date
Daniel Osvaldo Rahmanto	ebcb2fa294	fix(ext/node): fs.statfsSync and fs.statfs compatibility (#30662) ... Towards #29972 - Converts the polyfill to typescript. - Implement async op. - Allows `Buffer` type path. - Allows [parallel/test-fs-statfs.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-statfs.js) test to pass.	2025-09-18 16:03:30 +02:00
Daniel Osvaldo Rahmanto	d8c186196c	fix(ext/node): validate fs.read on empty buffer (#30706) ... Towards #29972 Allows https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-read-empty-buffer.js test to pass.	2025-09-16 11:16:17 +02:00
Daniel Osvaldo Rahmanto	0ad6a5eb7f	fix(ext/node): make fs.glob accepts URL cwd (#30705) ... Towards #29972 Allows https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-glob.mjs to pass.	2025-09-16 11:12:08 +02:00
Bartek Iwańczuk	4a1f63b930	Revert "fix(ext/node): fs.stat and fs.statSync compatibility (#30… (#30741) ... …637)" This reverts commit 432761aac5. The tests are causing flakes on Windows	2025-09-15 19:25:47 -04:00
Daniel Osvaldo Rahmanto	432761aac5	fix(ext/node): fs.stat and fs.statSync compatibility (#30637) ... Closes #30570 Changes in this PR: - Implement `ino`, `nlink`, and `blocks` properties of `Deno.FileInfo` on Windows. These changes are automatically reflected to the corresponding node stat function. In order to do so, I had to tinker with the [createByteStruct](a3a904da14/ext/fs/30_fs.js (L297)) function to create another optional int type, apart from `?u64`. It's common for small sized files on Windows (particularly NTFS file system) to have a `Stats.blocks` property of 0, and currently all 0 values with type `?u64` will be coerced into `null` by `createByteStruct`. - Refactor the `BigIntStats` and `Stats` class, to use the same class with Node.js that are provided from [utils.mjs](7f8e488c36/ext/node/polyfills/internal/fs/utils.mjs (L577)). Also ensures that all properties are not `null` or `undefined`. - Addresses the `prefer-primordials` lint rule.	2025-09-15 15:29:30 +02:00
Daniel Osvaldo Rahmanto	6050aea25a	fix(ext/node): set default callback for fs.close (#30720) ... Fixes #30718	2025-09-15 08:05:31 +00:00
Daniel Osvaldo Rahmanto	8244cd8e21	fix(ext/node): validate readlink arguments (#30691) ... Also accepts `Buffer` typed path. Allows https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-readlink-type-check.js test to pass. Towards #29972	2025-09-11 18:43:48 +02:00
Daniel Osvaldo Rahmanto	9c871d0a57	fix(ext/node): validate fs.close callback function (#30679) ... Towards #29972 Allows the [parallel/test-fs-close-errors.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-close-errors.js) test to pass, and also addresses the `prefer-primordials` lint rule #24236	2025-09-10 14:29:22 +00:00
Daniel Osvaldo Rahmanto	e60f5d2c52	fix(ext/node): fs.mkdtemp and fs.mkdtempSync compatibility (#30602) ... `fs.mkdtemp` and `fs.mkdtempSync` now accept `Buffer` and `Uint8Array` path. The implementation has been moved to Rust, including directory suffix generation and directory creation.	2025-09-05 16:12:42 -04:00
Daniel Osvaldo Rahmanto	e843a115fd	fix(ext/node): fs.symlink and fs.symlinkSync compatibility (#30555)	2025-09-03 17:48:13 -04:00
David Sherret	b1a510ce54	fix(node): regression where Node fs APIs required elevated permissions on Windows (#30535) ... Closes https://github.com/denoland/deno/issues/30534	2025-08-27 09:29:44 -04:00
Daniel Osvaldo Rahmanto	e463e57b0e	fix(ext/node): fs.exists and fs.existsSync compatibility (#30507) ... Closes #30506 Other changes: - Emit deprecation warning. - Allows [parallel/test-fs-exists.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-exists.js) to pass. - Allows [test-fs-symlink-dir-junction.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-symlink-dir-junction.js) to pass. Previously it always fail due to invalid assertion using `existsSync`.	2025-08-26 15:31:39 +02:00
Daniel Osvaldo R	0849b95ad3	fix(ext/node): validate callback on fs.mkdtemp and fs.stat (#30454) ... This allows [parallel/test-fs-makeStatsCallback.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-makeStatsCallback.js) and [parallel/test-fs-make-callback.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-make-callback.js) tests to pass.	2025-08-20 09:38:06 -04:00
Daniel Osvaldo R	e4a47febcd	fix(std/fs): implement chmod on windows (#30436) ... Closes #4357 On Windows, `chmod` can only change read and write permissions (https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/chmod-wchmod?view=msvc-170). It doesn't implement distinct permissions among group, owner, or others. Changes in this PR also enables `node:fs`’ `chmod` on Windows and fixes the `prefer-primordials` lint rule #24236.	2025-08-18 19:06:22 +02:00
Daniel Osvaldo R	55f74e809b	fix(ext/node): parse fs open options correctly (#30300) ... Fixes #30299 I decided to build the `OpenOptions` on the Rust side, because it's cheaper to pass integers to the op function and we can enable the fast op call. Also the tests that I added to the `config.toml` were already passing before this PR.	2025-08-05 11:12:22 +02:00
Daniel Osvaldo R	6ae4eda86a	fix(ext/node): define fs constants correctly across platforms (#30113)	2025-07-31 17:11:01 -04:00
Daniel Osvaldo R	8680d97b38	fix(ext/node): fs.open and fs.openSync compatibility (#30191) ... Notable changes: - Introduces a separate op between `Deno.open` and `node:fs.open`. - Removes redundant `existenceCheckRequired` and `Deno.lstatSync` calls, as the op layer already handles that when `options.create_new` is true and uses synchronous I/O when `O_SYNC` is passed. - Allows passing custom flags to the op (e.g. `O_SYNC`). - Addresses `prefer-primordials` lint rule. - Allows [parallel/test-fs-open.js](https://github.com/nodejs/node/blob/v23.9.0/test/parallel/test-fs-open.js) test to pass. There are also several tests that have passed before that I added to the config.toml.	2025-07-31 15:10:10 +00:00
Daniel Osvaldo R	af55e069ef	fix(ext/node): fs.rename and fs.renameSync compatibility (#30245)	2025-07-31 10:24:59 -04:00
Daniel Osvaldo R	eef8835e36	fix(ext/node): fs readv promisify compatibility (#30149)	2025-07-31 10:17:56 -04:00
Daniel Osvaldo R	d642f84203	fix(ext/node): fs.unlink and fs.unlinkSync compatibility (#30257) ... Improves compatibility with Node.js by validating the input parameters, accepting Buffer type paths, and converting thrown errors correctly. This PR also addresses `prefer-primordials` lint rule. These changes allow parallel/test-fs-unlink-type-check.js test to pass. Towards https://github.com/denoland/deno/issues/29972, https://github.com/denoland/deno/issues/24236.	2025-07-31 10:56:11 +02:00
Daniel Osvaldo R	a941d3ff23	fix(ext/node): validate fd is integer on fsync and fdatasync (#30215)	2025-07-28 11:01:00 -04:00
Daniel Osvaldo R	a8ef9e151d	fix(ext/node): fs.read and fs.write promisify compatibility (#30152) ... Towards #29972	2025-07-22 10:56:27 +02:00
Daniel Osvaldo R	0a01d63080	fix(ext/node): validate path parameters on link and linkSync (#30061)	2025-07-11 11:35:43 +09:00
Daniel Osvaldo R	1c16fde60f	fix(ext/node): don't throw error on invalid path input on exists and existsSync (#29971) ... Currently `fs.exists` and `fs.existsSync` throws error when invalid path is given to the input. The expected behavior is to: - Call the callback with false on `fs.exists`. - Return false on `fs.existsSync`. Towards #29972, #24236	2025-07-08 12:30:45 +02:00
Jeff Hykin	2f72884425	feat(node API): add fs.glob, fs.globSync, fs.promises.glob (#28972)	2025-07-01 11:35:45 +02:00
Daniel Osvaldo R	9bcd4366ee	fix(ext/node): add lchmod, lchmod promise, lchmodSync to node:fs (#29833)	2025-06-26 15:46:07 +09:00
Daniel Osvaldo R	0f0220e461	fix(ext/node): add fchmod and fchmodSync (#29791) ... This PR implements `node:fs` `fchmod` and `fchmodSync`. Towards https://github.com/denoland/deno/issues/27664 .	2025-06-18 12:48:14 +02:00
ctrl+d	e27447943b	fix(ext/node): fix fs.watchFile trigger (#29659) ... Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2025-06-11 12:37:59 +09:00
Andy Vu	90528fa9c9	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_symlink.ts (#29547) ... Towards #24236.	2025-06-02 11:15:21 +02:00
Andy Vu	90c320f71b	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_truncate.ts (#29422) ... Towards #24236. Replaces `Error`, `instanceof`, and `Promise.then()` with the equivalent primordials.	2025-05-25 23:49:39 +02:00
Yoshiya Hinosawa	3de21f1b8d	fix(ext/node): add fchown and fchownSync to node:fs (#29408)	2025-05-23 15:00:39 +09:00
Efe	cf8b9778d9	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_mkdtemp.ts (#29072) ... Towards #24236	2025-05-07 16:00:26 +02:00
Efe	943e3de3a4	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_opendir.ts (#29063)	2025-04-28 15:56:39 +09:00
ctrl+d	cf02f770aa	fix(ext/node): fix handling of abort signal in readFile (#29028) ... Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2025-04-25 14:48:12 +09:00
Asher Gomez	3aaa86b5c8	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_lstat.ts (#28644) ... Towards #24236	2025-03-28 10:52:33 -07:00
Asher Gomez	9a13bafa0e	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_realpath.ts (#28652) ... Towards #24236	2025-03-28 09:48:19 +01:00
Asher Gomez	512cf558d4	fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_readv.ts (#28645) ... Towards #24236	2025-03-28 09:47:36 +01:00
Divy Srivastava	52d528d21d	fix(ext/node): mkdir() parse file mode (#28609) ... Fixes https://github.com/denoland/deno/issues/28604	2025-03-25 09:33:41 +05:30
ZYSzys	4e0bf4b093	fix(ext/node): add FileHandle#sync (#27677)	2025-01-21 14:52:40 +09:00
Aaron Ang	9cb089f6db	fix(ext/node): add writev method to FileHandle (#27563) ... Part of #25554	2025-01-14 18:01:14 +09:00
Rajhans Jadhao	1dd5bd667c	fix(ext/node): use primordials in ext/node/polyfills/_fs_common.ts (#27589) ... Related to #24236	2025-01-10 13:51:50 +01:00
Nikolay Karadzhov	8cda4cf53d	feat(node/fs): Add a chmod method to the FileHandle class (#27522) ... Add the chmod method to the FileHandle class in node compat as part of #25554	2025-01-07 14:58:14 +01:00
Kenta Moriuchi	8fb073d7b4	chore: Happy New Year 2025 (#27509)	2024-12-31 19:12:39 +00:00
Filip Stevanovic	23f7032d56	fix(ext/node): add truncate method to the FileHandle class (#27389)	2024-12-20 13:23:51 +09:00
Filip Stevanovic	8fc4796ed5	fix(ext/node): Fix fs.access/fs.promises.access with X_OK mode parameter on Windows (#27407) ... - Fixes an issue on Windows where the `fs.constants.X_OK` flag caused `fs.access` and `fs.promises.access` to incorrectly throw a "permission denied" error - Introduced formatting changes due to the formatting tool - Fixed the issue by always removing the `X_OK` bit from the mode variable m (not sure if it's necessary to check for the presence of it in the `mode` param first?) - Updated unit tests to handle the mentioned constant - `X_OK` bit is ignored in the Node implementation and should behave like `F_OK` fs constants Node documentation: https://nodejs.org/api/fs.html#fsconstants fixes https://github.com/denoland/deno/issues/27405	2024-12-18 14:52:37 -08:00
Yoshiya Hinosawa	07737b03bc	fix(ext/node): accept file descriptor in fs.readFile(Sync) (#27252) ... closes #27123	2024-12-06 20:18:08 +09:00
Marvin Hagemeister	2fbc5fea83	fix(node/fs): support recursive option in readdir (#27179) ... We didn't support the `recursive` option of `fs.readdir()/fs.readdirSync()`. Fixes https://github.com/denoland/deno/issues/27175	2024-12-03 10:28:20 +01:00
Marvin Hagemeister	927352bd4e	fix(node/fs): add missing stat path argument validation (#27086) ... We didn't validate the `path` argument that's passed to `fs.stat()` and `fs.statSync()` which lead to wrong errors being thrown. The `@rollup/plugin-node-resolve` code calls it with `undefined` quite a lot which lead to `nitro` and `nuxt` failing. Fixes https://github.com/denoland/deno/issues/26700 --------- Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2024-11-27 08:35:39 +01:00
Trevor Manz	6b7e4c331b	fix(ext/node): add fs.promises.fstat and FileHandle#stat (#26719) ... Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>	2024-11-25 15:02:38 +09:00
Marvin Hagemeister	50538ba35d	fix(node/fs): missing uv error context for readFile (#27011) ... Dart's Node wrapper code in `npm:sass` does string slicing on the thrown error message which broke because of our missing uv error context. Code in question: ```js _systemErrorToFileSystemException0(callback) { var error, t1, exception, t2; try { t1 = callback.call$0(); return t1; } catch (exception) { error = A.unwrapException(exception); if (!type$.JsSystemError._is(error)) throw exception; t1 = error; t2 = J.getInterceptor$x(t1); throw A.wrapException(new A.FileSystemException0(J.substring$2$s(t2.get$message(t1), (A.S(t2.get$code(t1)) + ": ").length, J.get$length$asx(t2.get$message(t1)) - (", " + A.S(t2.get$syscall(t1)) + " '" + A.S(t2.get$path(t1)) + "'").length), J.get$path$x(error))); } } ``` Fixes https://github.com/denoland/deno/issues/26994	2024-11-22 22:42:27 +01:00