deno/tests/unit_node/_fs/_fs_exists_test.ts
Daniel Osvaldo Rahmanto e463e57b0e
Some checks are pending
ci / test debug linux-x86_64 (push) Blocked by required conditions
ci / test release linux-x86_64 (push) Blocked by required conditions
ci / test debug macos-x86_64 (push) Blocked by required conditions
ci / test release macos-x86_64 (push) Blocked by required conditions
ci / test debug windows-x86_64 (push) Blocked by required conditions
ci / test release windows-x86_64 (push) Blocked by required conditions
ci / build libs (push) Blocked by required conditions
ci / pre-build (push) Waiting to run
ci / test debug linux-aarch64 (push) Blocked by required conditions
ci / test release linux-aarch64 (push) Blocked by required conditions
ci / test debug macos-aarch64 (push) Blocked by required conditions
ci / test release macos-aarch64 (push) Blocked by required conditions
ci / bench release linux-x86_64 (push) Blocked by required conditions
ci / lint debug linux-x86_64 (push) Blocked by required conditions
ci / lint debug macos-x86_64 (push) Blocked by required conditions
ci / lint debug windows-x86_64 (push) Blocked by required conditions
ci / publish canary (push) Blocked by required conditions
fix(ext/node): fs.exists and fs.existsSync compatibility (#30507)
Closes #30506

Other changes:
- Emit deprecation warning.
- Allows
[parallel/test-fs-exists.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-exists.js)
to pass.
- Allows
[test-fs-symlink-dir-junction.js](https://github.com/nodejs/node/blob/v24.2.0/test/parallel/test-fs-symlink-dir-junction.js)
to pass. Previously it always fail due to invalid assertion using
`existsSync`.
2025-08-26 15:31:39 +02:00

88 lines
3.2 KiB
TypeScript

// Copyright 2018-2025 the Deno authors. MIT license.
import { assert, assertEquals, assertStringIncludes } from "@std/assert";
import { exists, existsSync } from "node:fs";
import { promisify } from "node:util";
import { join } from "@std/path";
import { symlink } from "node:fs/promises";
Deno.test("[std/node/fs] exists", async function () {
const availableFile = await new Promise((resolve) => {
const tmpFilePath = Deno.makeTempFileSync();
exists(tmpFilePath, (exists: boolean) => {
Deno.removeSync(tmpFilePath);
resolve(exists);
});
});
const notAvailableFile = await new Promise((resolve) => {
exists("./notAvailable.txt", (exists: boolean) => resolve(exists));
});
assertEquals(availableFile, true);
assertEquals(notAvailableFile, false);
});
Deno.test("[std/node/fs] existsSync", function () {
const tmpFilePath = Deno.makeTempFileSync();
assertEquals(existsSync(tmpFilePath), true);
Deno.removeSync(tmpFilePath);
assertEquals(existsSync("./notAvailable.txt"), false);
});
Deno.test("[std/node/fs] promisify(exists)", async () => {
const tmpFilePath = await Deno.makeTempFile();
try {
const existsPromisified = promisify(exists);
assert(await existsPromisified(tmpFilePath));
assert(!await existsPromisified("./notAvailable.txt"));
} finally {
await Deno.remove(tmpFilePath);
}
});
Deno.test("[std/node/fs] exists callback isn't called twice if error is thrown", async () => {
// This doesn't use `assertCallbackErrorUncaught()` because `exists()` doesn't return a standard node callback, which is what it expects.
const tempFile = await Deno.makeTempFile();
const importUrl = new URL("node:fs", import.meta.url);
const command = new Deno.Command(Deno.execPath(), {
args: [
"eval",
"--no-check",
`
import { exists } from ${JSON.stringify(importUrl)};
exists(${JSON.stringify(tempFile)}, (exists) => {
// If the bug is present and the callback is called again with false (meaning an error occurred),
// don't throw another error, so if the subprocess fails we know it had the correct behaviour.
if (exists) throw new Error("success");
});`,
],
});
const { success, stderr } = await command.output();
await Deno.remove(tempFile);
assert(!success);
assertStringIncludes(new TextDecoder().decode(stderr), "Error: success");
});
Deno.test("[std/node/fs] exists should return false on invalid symlink", async () => {
const tmpDir = await Deno.makeTempDir();
const symlinkTarget = join(tmpDir, "noop.link");
const symlinkPath = join(tmpDir, "link");
try {
await symlink(symlinkTarget, symlinkPath);
const isExists = await promisify(exists)(symlinkPath);
assert(!isExists);
} finally {
await Deno.remove(tmpDir, { recursive: true });
}
});
Deno.test("[std/node/fs] existsSync should return false on invalid symlink", async () => {
const tmpDir = await Deno.makeTempDir();
const symlinkTarget = join(tmpDir, "noop.link");
const symlinkPath = join(tmpDir, "link");
try {
await symlink(symlinkTarget, symlinkPath);
assert(!existsSync(symlinkPath));
} finally {
await Deno.remove(tmpDir, { recursive: true });
}
});