language-servers/erg
1
0
Fork 0
mirror of https://github.com/erg-lang/erg.git synced 2025-08-04 02:39:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: improve error message for missing args

Browse source
This commit is contained in:
Shunsuke Shibayama 2023-10-11 22:08:39 +09:00
parent 5e580422c3
commit 22096ceccf
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/erg_compiler/context/inquire.rs
View file

@ -1629,6 +1629,7 @@ impl Context {
{
errs.append(&mut es);
}
passed_params.insert("self".into());
non_default_params
} else {
subr.non_default_params.iter()
@ -1736,12 +1737,16 @@ impl Context {
.non_default_params
.iter()
.enumerate()
.map(|(i, pt)| {
pt.name().cloned().unwrap_or_else(|| {
Str::from(format!("({} param)", ordinal_num(i + 1)))
})
.filter(|(_, pt)| {
pt.name().map_or(true, |name| !passed_params.contains(name))
})
.map(|(i, pt)| {
let n = if is_method { i } else { i + 1 };
let nth = format!("({} param)", ordinal_num(n));
pt.name()
.map_or(nth.clone(), |name| format!("{name} {nth}"))
.into()
})
.filter(|pt| !passed_params.contains(pt))
.collect::<Vec<_>>();
if !missing_params.is_empty() {
return Err(TyCheckErrors::from(TyCheckError::args_missing_error(