language-servers/erg
1
0
Fork 0
mirror of https://github.com/erg-lang/erg.git synced 2025-09-28 04:09:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: {default, variable} parameter bugs

Browse source
This commit is contained in:
Shunsuke Shibayama 2024-04-24 15:24:05 +09:00
parent dc9cbf98a7
commit 3d7283cb01
8 changed files with 131 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

31
crates/erg_compiler/context/unify.rs
View file

@ -1,4 +1,5 @@
//! provides type variable related operations
use std::iter::repeat;
use std::mem;
use std::option::Option;
@ -1252,14 +1253,28 @@ impl<'c, 'l, 'u, L: Locational> Unifier<'c, 'l, 'u, L> {
}
}
(Subr(sub_subr), Subr(sup_subr)) => {
sub_subr
.non_default_params
.iter()
.zip(sup_subr.non_default_params.iter())
.try_for_each(|(sub, sup)| {
// contravariant
self.sub_unify(sup.typ(), sub.typ())
})?;
// (Int, *Int) -> ... <: (T, U, V) -> ...
if let Some(sub_var) = sub_subr.var_params.as_deref() {
sub_subr
.non_default_params
.iter()
.chain(repeat(sub_var))
.zip(sup_subr.non_default_params.iter())
.try_for_each(|(sub, sup)| {
// contravariant
self.sub_unify(sup.typ(), sub.typ())
})?;
} else {
sub_subr
.non_default_params
.iter()
.chain(sub_subr.default_params.iter())
.zip(sup_subr.non_default_params.iter())
.try_for_each(|(sub, sup)| {
// contravariant
self.sub_unify(sup.typ(), sub.typ())
})?;
}
sub_subr
.var_params
.iter()