From 43a3fa6e30e8817de34a0a50269ac67bf5521831 Mon Sep 17 00:00:00 2001
From: Shunsuke Shibayama <sbym1346@gmail.com>
Date: Sun, 25 Dec 2022 20:22:03 +0900
Subject: [PATCH] eliminate `lpop` and use `into_iter`

---
 compiler/erg_compiler/reorder.rs | 4 ++--
 compiler/erg_parser/desugar.rs   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/compiler/erg_compiler/reorder.rs b/compiler/erg_compiler/reorder.rs
index 16ec53ed..51617fb1 100644
--- a/compiler/erg_compiler/reorder.rs
+++ b/compiler/erg_compiler/reorder.rs
@@ -28,10 +28,10 @@ impl Reorderer {
         }
     }
 
-    pub fn reorder(mut self, mut ast: AST) -> Result<AST, TyCheckErrors> {
+    pub fn reorder(mut self, ast: AST) -> Result<AST, TyCheckErrors> {
         log!(info "the reordering process has started.");
         let mut new = vec![];
-        while let Some(chunk) = ast.module.lpop() {
+        for chunk in ast.module.into_iter() {
             match chunk {
                 Expr::Def(def) => {
                     match def.body.block.first().unwrap() {
diff --git a/compiler/erg_parser/desugar.rs b/compiler/erg_parser/desugar.rs
index fafa3239..5b88ff0e 100644
--- a/compiler/erg_parser/desugar.rs
+++ b/compiler/erg_parser/desugar.rs
@@ -305,9 +305,9 @@ impl Desugarer {
 
     /// `fib 0 = 0; fib 1 = 1; fib n = fib(n-1) + fib(n-2)`
     /// -> `fib n = match n, (0 -> 0), (1 -> 1), n -> fib(n-1) + fib(n-2)`
-    fn desugar_multiple_pattern_def(&self, mut module: Module) -> Module {
+    fn desugar_multiple_pattern_def(&self, module: Module) -> Module {
         let mut new = Module::with_capacity(module.len());
-        while let Some(chunk) = module.lpop() {
+        for chunk in module.into_iter() {
             match chunk {
                 Expr::Def(def) if def.is_subr() => {
                     if let Some(Expr::Def(previous)) = new.last() {