language-servers/erg
1
0
Fork 0
mirror of https://github.com/erg-lang/erg.git synced 2025-08-03 18:29:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: bugs generating unintended circular references

Browse source
This commit is contained in:
Shunsuke Shibayama 2023-05-18 17:33:08 +09:00
parent 0b0badfef4
commit f39836abb0
10 changed files with 119 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/erg_compiler/context/eval.rs
View file

@ -1242,7 +1242,7 @@ impl Context {
let (sub, sup) = fv.get_subsup().unwrap();
if self.is_trait(&sup) && !self.trait_impl_exists(&sub, &sup) {
// link to `Never` to prevent double errors from being reported
fv.link(&Never);
lhs.link(&Never);
let sub = if cfg!(feature = "debug") {
sub
} else {
@ -1682,8 +1682,8 @@ impl Context {
}
}
}
if let TyParam::FreeVar(lhs) = &lhs {
if let Some((sub, sup)) = lhs.get_subsup() {
if let TyParam::FreeVar(fv) = &lhs {
if let Some((sub, sup)) = fv.get_subsup() {
if self.is_trait(&sup) && !self.trait_impl_exists(&sub, &sup) {
// to prevent double error reporting
lhs.link(&TyParam::t(Never));
@ -1781,8 +1781,8 @@ impl Context {
err
})
.ok()?;
for (param, arg) in instance.typarams().into_iter().zip(args.into_iter()) {
self.sub_unify_tp(&arg, &param, None, &(), false).ok()?;
for (param, arg) in instance.typarams().iter().zip(args.iter()) {
self.sub_unify_tp(arg, param, None, &(), false).ok()?;
}
let ty_obj = if self.is_class(&instance) {
ValueObj::builtin_class(instance)