Report an error if given L1500 for elp lint command

Summary:
We changed the error code for `unused include` from `L1500` to `W0020`, because the `L` range belongs to diagnostics from the OTP compiler, and it is an ELP-native diagnostic.
Report a useful error if `L1500` is passed as the diagnostic filter for `elp lint`

Reviewed By: VLanvin

Differential Revision: D55186509

fbshipit-source-id: 53a445d51830cbee224277cc1c6a27b086a0adf1

crates/elp/src/bin/lint_cli.rs

@@ -180,6 +180,11 @@ pub fn do_codemod(cli: &mut dyn Cli, loaded: &mut LoadResult, args: &Lint) -> Re
             }
 
             if let Some(diagnostic_filter) = diagnostic_filter {
+                // We have replaced L1500 with W0020. Generate an error if we get L1500.
+                if diagnostic_filter == "L1500" {
+                    bail!("Code L1500 has been superseded by W0020");
+                }
+
                 let diagnostic_filter = DiagnosticCode::from(diagnostic_filter.as_str());
                 // Make sure we do not mask the one we explicitly asked for
                 disabled_diagnostics.remove(&diagnostic_filter);

crates/elp/src/bin/main.rs

@@ -1225,6 +1225,21 @@ mod tests {
         .expect("Bad test");
     }
 
+    #[test_case(false ; "rebar")]
+    #[test_case(true  ; "buck")]
+    fn lint_errors_on_deprecated_l1500(buck: bool) {
+        let tmp_dir = TempDir::new().expect("Could not create temporary directory");
+        let tmp_path = tmp_dir.path();
+        fs::create_dir_all(tmp_path).expect("Could not create temporary directory path");
+        simple_snapshot_expect_stderror(
+            args_vec!["lint", "--module", "app_a", "--diagnostic-filter", "L1500",],
+            "diagnostics",
+            expect_file!("../resources/test/diagnostics/parse_elp_l1500_deprecated.stdout"),
+            buck,
+            None,
+        )
+    }
+
     #[test_case(false ; "rebar")]
     #[test_case(true  ; "buck")]
     fn lint_edoc(buck: bool) {

crates/elp/src/resources/test/diagnostics/parse_elp_l1500_deprecated.stdout

@@ -0,0 +1 @@
+Code L1500 has been superseded by W0020