From 05d41d6cafe402361b17d5d29e09800267ad2d7d Mon Sep 17 00:00:00 2001 From: hippietrail Date: Wed, 29 Jan 2025 19:56:13 +0800 Subject: [PATCH 1/3] feat(core): even more holidays I went through and verified every two-word "Day" holiday in the English Wiktionary. These are the ones that passed muster. --- .../proper_noun_capitalization_linters.rs | 93 ++++++++++++++++++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/harper-core/src/linting/proper_noun_capitalization_linters.rs b/harper-core/src/linting/proper_noun_capitalization_linters.rs index 30bb4e18..97aad2e8 100644 --- a/harper-core/src/linting/proper_noun_capitalization_linters.rs +++ b/harper-core/src/linting/proper_noun_capitalization_linters.rs @@ -114,29 +114,120 @@ create_linter_for!( SequencePattern::default() .then(Box::new(EitherPattern::new(vec![ Box::new(WordSet::all(&[ + "Absolution", + "Admission", + "Alaska", + "Anzac", + "ANZAC", + "Arbor", "Armistice", + "Ascension", + "Australia", + "Ayurveda", + "Bastille", + "Bonifacio", "Boxing", + "Canada", + "Career", + "Chewidden", "Christmas", + "Class", "Columbus", + "Commonwealth", + "D", + "Darwin", + "Discovery", + "Distaff", + "Dominion", "Earth", "Easter", + "Election", + "Emancipation", + "Empire", + "Evolution", + "Family", + "Father's", + "Father’s", "Fathers'", + "Fathers’", "Flag", + "Forefathers'", + "Forefathers’", + "Foundation", + "Freedom", + "Galentine's", + "Galentine’s", "Groundhog", + "Gypsy", "Halloween", "Independence", + "Invasion", + "Ivy", + "Jamhuri", + "Jubilee", + "Kamehameha", + "Kenyatta", "Labor", "Labour", + "Lady", + "Land", + "Lei", + "Madaraka", + "Mashujaa", "May", "Memorial", + "Merdeka", + "Midsummer", + "Midsummer's", + "Midsummer’s", + "Mother's", + "Mother’s", "Mothers'", + "Mothers’", + "Nakba", + "Nevada", + "Occupation", "Parents", + "Patrick's", + "Patrick’s", + "Patriots'", + "Patriots’", + "Pi", + "Picrous", + "Pioneer", "Presidents'", + "Remembrance", + "Republic", + "Restoration", + "Rizal", + "Roc", + "Rock", + "Seward's", + "Seward’s", + "Singles'", + "Singles’", + "Statehood", "Tax", "Thanksgiving", + "Treason", + "Ulster", "Valentine's", + "Valentine’s", + "VE", + "VJ", + "VP", "Veterans", - "Years" + "Victoria", + "Victory", + "Waffle", + "Waitangi", + "Wattle", + "White", + "Wren", + "Years", + "Year's", + "Year’s", + "Youth", ])), Box::new( SequencePattern::default() From cb7f7969080bf2ace8283f92ecb87aaa91de3ad2 Mon Sep 17 00:00:00 2001 From: Elijah Potter Date: Wed, 29 Jan 2025 15:02:27 -0700 Subject: [PATCH 2/3] feat: issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 30 +++++++++++++++++++ .../report-grammatical-error.md | 20 +++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/report-grammatical-error.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..c12f526c --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,30 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Platform** +What platform has the issue? Is it in Obsidian, Neovim, or Visual Studio Code? Something else? + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/report-grammatical-error.md b/.github/ISSUE_TEMPLATE/report-grammatical-error.md new file mode 100644 index 00000000..29243d91 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/report-grammatical-error.md @@ -0,0 +1,20 @@ +--- +name: Report Grammatical Error +about: If a grammatical error is not found by Harper, let us tus now +title: '' +labels: enhancement, harper-core, linting +assignees: '' + +--- + +## Description + +Give a detailed description of the grammatical error Harper should be able to find. + +## Resources + +If there are any resources online we can reference that described grammatical rules, let us know. + +## Examples + +Please provide at least three examples of the grammatical error in real text. From be9644f8fb072e050a4e0ba38a36bbc7051b4ace Mon Sep 17 00:00:00 2001 From: hippietrail Date: Thu, 30 Jan 2025 10:16:45 +0800 Subject: [PATCH 3/3] =?UTF-8?q?remove=20dupe=20entries=20with=20curly=20?= =?UTF-8?q?=E2=80=99=20apostrophes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../linting/proper_noun_capitalization_linters.rs | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/harper-core/src/linting/proper_noun_capitalization_linters.rs b/harper-core/src/linting/proper_noun_capitalization_linters.rs index 97aad2e8..feadeb0e 100644 --- a/harper-core/src/linting/proper_noun_capitalization_linters.rs +++ b/harper-core/src/linting/proper_noun_capitalization_linters.rs @@ -147,16 +147,12 @@ create_linter_for!( "Evolution", "Family", "Father's", - "Father’s", "Fathers'", - "Fathers’", "Flag", "Forefathers'", - "Forefathers’", "Foundation", "Freedom", "Galentine's", - "Galentine’s", "Groundhog", "Gypsy", "Halloween", @@ -179,19 +175,14 @@ create_linter_for!( "Merdeka", "Midsummer", "Midsummer's", - "Midsummer’s", "Mother's", - "Mother’s", "Mothers'", - "Mothers’", "Nakba", "Nevada", "Occupation", "Parents", "Patrick's", - "Patrick’s", "Patriots'", - "Patriots’", "Pi", "Picrous", "Pioneer", @@ -203,16 +194,13 @@ create_linter_for!( "Roc", "Rock", "Seward's", - "Seward’s", "Singles'", - "Singles’", "Statehood", "Tax", "Thanksgiving", "Treason", "Ulster", "Valentine's", - "Valentine’s", "VE", "VJ", "VP", @@ -226,7 +214,6 @@ create_linter_for!( "Wren", "Years", "Year's", - "Year’s", "Youth", ])), Box::new(