language-servers/harper
1
0
Fork 0
mirror of https://github.com/Automattic/harper.git synced 2025-12-23 08:48:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

feat(core): add threw as a suggestion (#2088)

Browse source
This commit is contained in:
Elijah Potter 2025-10-22 10:46:02 -06:00 • committed by GitHub
parent 67f2ca0b02
commit bbcfb2b35e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

24
harper-core/src/linting/throw_away.rs
View file

@ -33,21 +33,27 @@ impl ExprLinter for ThrowAway {
Some(Lint {
span: typo.span,
lint_kind: LintKind::Typo,
suggestions: vec![Suggestion::replace_with_match_case_str("throw", original)],
message: "Use `throw away` when you want to discard something.".to_string(),
suggestions: vec![
Suggestion::replace_with_match_case_str("throw", original),
Suggestion::replace_with_match_case_str("threw", original),
],
message: "Use `throw away` or `threw away`, depending on the tense you need."
.to_string(),
priority: 60,
})
}
fn description(&self) -> &str {
"Finds the typo `through away` and suggests `throw away` instead."
"Finds the typo `through away` and suggests `throw away` or `threw away` instead."
}
}
#[cfg(test)]
mod tests {
use super::ThrowAway;
use crate::linting::tests::{assert_lint_count, assert_no_lints, assert_suggestion_result};
use crate::linting::tests::{
assert_lint_count, assert_no_lints, assert_nth_suggestion_result, assert_suggestion_result,
};
#[test]
fn corrects_simple_case() {
@ -58,6 +64,16 @@ mod tests {
);
}
#[test]
fn offers_past_tense_option() {
assert_nth_suggestion_result(
"We through away the old code.",
ThrowAway::default(),
"We threw away the old code.",
1,
);
}
#[test]
fn corrects_sentence_start_capital() {
assert_suggestion_result(