language-servers/harper
1
0
Fork 0
mirror of https://github.com/Automattic/harper.git synced 2025-12-23 08:48:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fascinated about (#2319)

Browse source 
* feat: wip: fascinated about→fascinated in/by

* feat: fascinated about → fascinated by/with

* fix: undo mess from `git stash pop`
This commit is contained in:
Andrew Dunbar 2025-12-10 21:50:54 +00:00 • committed by GitHub
parent b642c99212
commit e6579442f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 189 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

184
harper-core/src/linting/fascinated_by.rs Normal file
View file

@ -0,0 +1,184 @@
use crate::{
CharStringExt, Lint, Token,
expr::{Expr, SequenceExpr},
linting::{ExprLinter, LintKind, Suggestion, expr_linter::Chunk},
};
pub struct FascinatedBy {
expr: Box<dyn Expr>,
}
impl Default for FascinatedBy {
fn default() -> Self {
Self {
expr: Box::new(SequenceExpr::aco("fascinated").t_ws().then_preposition()),
}
}
}
impl ExprLinter for FascinatedBy {
type Unit = Chunk;
fn expr(&self) -> &dyn Expr {
self.expr.as_ref()
}
fn match_to_lint(&self, toks: &[Token], src: &[char]) -> Option<Lint> {
let prep_span = toks.last()?.span;
let prep_chars = prep_span.get_content(src);
if prep_chars.eq_any_ignore_ascii_case_str(&["by", "with"]) {
return None;
}
Some(Lint {
span: prep_span,
lint_kind: LintKind::Usage,
suggestions: vec![
Suggestion::replace_with_match_case_str("by", prep_chars),
Suggestion::replace_with_match_case_str("with", prep_chars),
],
message: "The correct prepositions to use with `fascinated` are `by` or `with`."
.to_string(),
..Default::default()
})
}
fn description(&self) -> &str {
"Ensures the correct prepositions are used with `fascinated` (e.g., `fascinated by` or `fascinated with`)."
}
}
#[cfg(test)]
mod tests {
use crate::linting::{fascinated_by::FascinatedBy, tests::assert_good_and_bad_suggestions};
#[test]
fn fix_amiga() {
assert_good_and_bad_suggestions(
"Now, one aspect of the Amiga that I've always been fascinated about is making my own games for the Amiga.",
FascinatedBy::default(),
&[
"Now, one aspect of the Amiga that I've always been fascinated by is making my own games for the Amiga.",
"Now, one aspect of the Amiga that I've always been fascinated with is making my own games for the Amiga.",
][..],
&[],
);
}
#[test]
fn fix_microbit() {
assert_good_and_bad_suggestions(
"also why I am very fascinated about the micro:bit itself",
FascinatedBy::default(),
&[
"also why I am very fascinated by the micro:bit itself",
"also why I am very fascinated with the micro:bit itself",
][..],
&[],
);
}
#[test]
fn fix_software_development() {
assert_good_and_bad_suggestions(
"Self-learner, fascinated about software development, especially computer graphics and web - marcus-phi.",
FascinatedBy::default(),
&[
"Self-learner, fascinated by software development, especially computer graphics and web - marcus-phi.",
"Self-learner, fascinated with software development, especially computer graphics and web - marcus-phi.",
][..],
&[],
);
}
#[test]
fn fix_computer_science() {
assert_good_and_bad_suggestions(
"Fascinated about Computer Science, Finance and Statistics.",
FascinatedBy::default(),
&[
"Fascinated by Computer Science, Finance and Statistics.",
"Fascinated with Computer Science, Finance and Statistics.",
][..],
&[],
);
}
#[test]
fn fix_possibilities() {
assert_good_and_bad_suggestions(
"m relatively new to deCONZ and Conbee2 but already very fascinated about the possibilities compared to Philips and Ikea's",
FascinatedBy::default(),
&[
"m relatively new to deCONZ and Conbee2 but already very fascinated by the possibilities compared to Philips and Ikea's",
"m relatively new to deCONZ and Conbee2 but already very fascinated with the possibilities compared to Philips and Ikea's",
][..],
&[],
);
}
#[test]
fn fix_project() {
assert_good_and_bad_suggestions(
"I have been using browser use in local mode for a while and i am pretty fascinated about the project.",
FascinatedBy::default(),
&[
"I have been using browser use in local mode for a while and i am pretty fascinated by the project.",
"I have been using browser use in local mode for a while and i am pretty fascinated with the project.",
][..],
&[],
);
}
#[test]
fn fix_work() {
assert_good_and_bad_suggestions(
"Hey guys, I am really fascinated about your work and I tried to build Magisk so I will be able to contribute for the project.",
FascinatedBy::default(),
&[
"Hey guys, I am really fascinated by your work and I tried to build Magisk so I will be able to contribute for the project.",
"Hey guys, I am really fascinated with your work and I tried to build Magisk so I will be able to contribute for the project.",
][..],
&[],
);
}
#[test]
fn fix_ais() {
assert_good_and_bad_suggestions(
"I am a retired Dutch telecom engineer and fascinated about AIS applications.",
FascinatedBy::default(),
&[
"I am a retired Dutch telecom engineer and fascinated by AIS applications.",
"I am a retired Dutch telecom engineer and fascinated with AIS applications.",
][..],
&[],
);
}
#[test]
fn fix_innovative_ideas() {
assert_good_and_bad_suggestions(
"Software Developer fascinated about innovative ideas, love to learn and share new technologies and ideas.",
FascinatedBy::default(),
&[
"Software Developer fascinated by innovative ideas, love to learn and share new technologies and ideas.",
"Software Developer fascinated with innovative ideas, love to learn and share new technologies and ideas.",
][..],
&[],
);
}
#[test]
fn fix_coding() {
assert_good_and_bad_suggestions(
"m fascinated about coding and and sharing my code to the world.",
FascinatedBy::default(),
&[
"m fascinated by coding and and sharing my code to the world.",
"m fascinated with coding and and sharing my code to the world.",
][..],
&[],
);
}
}

2
harper-core/src/linting/interested_in.rs
View file

@ -42,7 +42,7 @@ impl ExprLinter for InterestedIn {
Some(Lint {
span: prep_span,
lint_kind: LintKind::Grammar,
lint_kind: LintKind::Usage,
suggestions: vec![Suggestion::replace_with_match_case(
"in".chars().collect(),
prep_chars,

2
harper-core/src/linting/jealous_of.rs
View file

@ -43,7 +43,7 @@ impl ExprLinter for JealousOf {
Some(Lint {
span: from_token.span,
lint_kind: LintKind::WordChoice,
lint_kind: LintKind::Usage,
suggestions: vec![Suggestion::replace_with_match_case_str(
"of",
from_token.span.get_content(source),

2
harper-core/src/linting/lint_group.rs
View file

@ -61,6 +61,7 @@ use super::expand_memory_shorthands::ExpandMemoryShorthands;
use super::expand_time_shorthands::ExpandTimeShorthands;
use super::expr_linter::run_on_chunk;
use super::far_be_it::FarBeIt;
use super::fascinated_by::FascinatedBy;
use super::feel_fell::FeelFell;
use super::few_units_of_time_ago::FewUnitsOfTimeAgo;
use super::filler_words::FillerWords;
@ -533,6 +534,7 @@ impl LintGroup {
insert_expr_rule!(ExpandMemoryShorthands, true);
insert_expr_rule!(ExpandTimeShorthands, true);
insert_expr_rule!(FarBeIt, true);
insert_expr_rule!(FascinatedBy, true);
insert_expr_rule!(FeelFell, true);
insert_expr_rule!(FewUnitsOfTimeAgo, true);
insert_expr_rule!(FillerWords, true);

1
harper-core/src/linting/mod.rs
View file

@ -56,6 +56,7 @@ mod expand_memory_shorthands;
mod expand_time_shorthands;
mod expr_linter;
mod far_be_it;
mod fascinated_by;
mod feel_fell;
mod few_units_of_time_ago;
mod filler_words;