harper/harper-comments/src/comment_parser.rs
rnxpyke 3b1b126dd7
Some checks are pending
Binaries / harper-cli - macOS-aarch64 (push) Waiting to run
Binaries / harper-cli - Linux-aarch64-GNU (push) Waiting to run
Binaries / harper-cli - Linux-aarch64-musl (push) Waiting to run
Binaries / harper-cli - macOS-x86_64 (push) Waiting to run
Binaries / harper-cli - Linux-x86_64-GNU (push) Waiting to run
Binaries / harper-cli - Linux-x86_64-musl (push) Waiting to run
Binaries / harper-cli - Windows-x86_64 (push) Waiting to run
Binaries / harper-ls - macOS-aarch64 (push) Waiting to run
Binaries / harper-ls - Linux-aarch64-GNU (push) Waiting to run
Binaries / harper-ls - Linux-aarch64-musl (push) Waiting to run
Binaries / harper-ls - macOS-x86_64 (push) Waiting to run
Binaries / harper-ls - Linux-x86_64-GNU (push) Waiting to run
Binaries / harper-ls - Linux-x86_64-musl (push) Waiting to run
Binaries / harper-ls - Windows-x86_64 (push) Waiting to run
Build Web / build-web (push) Waiting to run
Chrome Plugin / chrome-plugin (push) Waiting to run
Just Checks / just check-js (push) Waiting to run
Just Checks / just check-rust (push) Waiting to run
Just Checks / just test-chrome-plugin (push) Waiting to run
Just Checks / just test-firefox-plugin (push) Waiting to run
Just Checks / just test-harperjs (push) Waiting to run
Just Checks / just test-obsidian (push) Waiting to run
Just Checks / just test-rust (push) Waiting to run
Just Checks / just test-vscode (push) Waiting to run
VS Code Plugin / alpine-arm64 (push) Waiting to run
VS Code Plugin / alpine-x64 (push) Waiting to run
VS Code Plugin / darwin-arm64 (push) Waiting to run
VS Code Plugin / darwin-x64 (push) Waiting to run
VS Code Plugin / linux-arm64 (push) Waiting to run
VS Code Plugin / linux-armhf (push) Waiting to run
VS Code Plugin / linux-x64 (push) Waiting to run
VS Code Plugin / win32-arm64 (push) Waiting to run
VS Code Plugin / win32-x64 (push) Waiting to run
WordPress Plugin / wp-plugin (push) Waiting to run
test: add failing example for markdown comment parser (#1948)
* test: add failing example for markdown comment parser

* fix(core): crash

* fuzz: add other fuzzing hang

* fix(comments): infinite loop

---------

Co-authored-by: Elijah Potter <me@elijahpotter.dev>
2025-11-18 23:20:17 +00:00

146 lines
5.1 KiB
Rust

use std::path::Path;
use crate::comment_parsers;
use comment_parsers::{Go, JavaDoc, JsDoc, Lua, Solidity, Unit};
use harper_core::Token;
use harper_core::parsers::{self, MarkdownOptions, Parser};
use harper_core::spell::MutableDictionary;
use tree_sitter::Node;
use crate::masker::CommentMasker;
pub struct CommentParser {
inner: parsers::Mask<CommentMasker, Box<dyn Parser>>,
}
impl CommentParser {
pub fn create_ident_dict(&self, source: &[char]) -> Option<MutableDictionary> {
self.inner.masker.create_ident_dict(source)
}
pub fn new_from_language_id(
language_id: &str,
markdown_options: MarkdownOptions,
) -> Option<Self> {
let language = match language_id {
"c" => tree_sitter_c::LANGUAGE,
"clojure" => tree_sitter_clojure::LANGUAGE,
"cmake" => tree_sitter_cmake::LANGUAGE,
"cpp" => tree_sitter_cpp::LANGUAGE,
"csharp" => tree_sitter_c_sharp::LANGUAGE,
"dart" => harper_tree_sitter_dart::LANGUAGE,
"go" => tree_sitter_go::LANGUAGE,
"haskell" => tree_sitter_haskell::LANGUAGE,
"java" => tree_sitter_java::LANGUAGE,
"javascript" => tree_sitter_javascript::LANGUAGE,
"javascriptreact" => tree_sitter_typescript::LANGUAGE_TSX,
"kotlin" => tree_sitter_kotlin_ng::LANGUAGE,
"lua" => tree_sitter_lua::LANGUAGE,
"nix" => tree_sitter_nix::LANGUAGE,
"php" => tree_sitter_php::LANGUAGE_PHP,
"ruby" => tree_sitter_ruby::LANGUAGE,
"rust" => tree_sitter_rust::LANGUAGE,
"scala" => tree_sitter_scala::LANGUAGE,
"shellscript" => tree_sitter_bash::LANGUAGE,
"solidity" => tree_sitter_solidity::LANGUAGE,
"swift" => tree_sitter_swift::LANGUAGE,
"toml" => tree_sitter_toml_ng::LANGUAGE,
"typescript" => tree_sitter_typescript::LANGUAGE_TYPESCRIPT,
"typescriptreact" => tree_sitter_typescript::LANGUAGE_TSX,
_ => return None,
};
let comment_parser: Box<dyn Parser> = match language_id {
"go" => Box::new(Go::new_markdown(markdown_options)),
"java" => Box::new(JavaDoc::default()),
"javascript" | "javascriptreact" | "typescript" | "typescriptreact" => {
Box::new(JsDoc::new_markdown(markdown_options))
}
"lua" => Box::new(Lua::new_markdown(markdown_options)),
"solidity" => Box::new(Solidity::new_markdown(markdown_options)),
_ => Box::new(Unit::new_markdown(markdown_options)),
};
Some(Self {
inner: parsers::Mask::new(
CommentMasker::new(language.into(), Self::node_condition),
comment_parser,
),
})
}
/// Infer the programming language from a provided filename.
pub fn new_from_filename(filename: &Path, markdown_options: MarkdownOptions) -> Option<Self> {
Self::new_from_language_id(Self::filename_to_filetype(filename)?, markdown_options)
}
/// Convert a provided path to a corresponding Language Server Protocol file
/// type.
///
/// Note to contributors: try to keep this in sync with
/// [`Self::new_from_language_id`]
fn filename_to_filetype(path: &Path) -> Option<&'static str> {
Some(match path.extension()?.to_str()? {
"c" => "c",
"bb" | "cljc" | "cljd" | "clj" | "cljs" => "clojure",
"cmake" => "cmake",
"cpp" | "h" => "cpp",
"cs" => "csharp",
"dart" => "dart",
"go" => "go",
"hs" => "haskell",
"java" => "java",
"js" => "javascript",
"jsx" => "javascriptreact",
"kt" | "kts" => "kotlin",
"lua" => "lua",
"nix" => "nix",
"php" => "php",
"rb" => "ruby",
"rs" => "rust",
"sbt" | "sc" | "scala" | "mill" => "scala",
"bash" | "sh" => "shellscript",
"sol" => "solidity",
"swift" => "swift",
"toml" => "toml",
"ts" => "typescript",
"tsx" => "typescriptreact",
_ => return None,
})
}
fn node_condition(n: &Node) -> bool {
n.kind().contains("comment")
}
}
impl Parser for CommentParser {
fn parse(&self, source: &[char]) -> Vec<Token> {
self.inner.parse(source)
}
}
#[cfg(test)]
mod tests {
use super::CommentParser;
use harper_core::parsers::{MarkdownOptions, StrParser};
#[test]
fn hang() {
use std::sync::mpsc::channel;
use std::thread;
use std::time::Duration;
let (tx, rx) = channel::<()>();
let handle = thread::spawn(move || {
let opts = MarkdownOptions::default();
let parser = CommentParser::new_from_language_id("java", opts).unwrap();
let _res = parser.parse_str("//{@j");
tx.send(()).expect("send failed");
});
rx.recv_timeout(Duration::from_secs(10)).expect("timed out");
handle.join().expect("failed to join");
}
}