language-servers/nil
1
0
Fork 0
mirror of https://github.com/oxalica/nil.git synced 2025-12-23 09:19:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Suppress unused warnings for flake auto-inputs

Browse source 
Fixes #73
This commit is contained in:
oxalica 2023-04-14 03:04:26 +08:00
parent a55f287f24
commit df541a798d
1 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

37
crates/ide/src/def/liveness.rs
View file

@ -168,7 +168,15 @@ pub(crate) fn liveness_check_query(
// `{ foo [, ...] }[@bar]: ...`
// ^ Unused and removable, only for packages and configurations.
if let Some(pat) = pat {
if must_use_params_expr == Some(expr) {
if must_use_params_expr == Some(expr)
// For flakes,
// `outputs = { foo [, ...] }@bar: ...`
// ^ Always considered used.
// It causes Nix to add inputs from registry automatically,
// and user can access it via `var` elsewhere.
// Tested in `flake_output_with_universal`.
&& (!is_flake_outputs || param.is_none())
{
unused_defs.extend(pat.fields.iter().filter_map(|&(name, _)| {
let name = name?;
if visited_defs.get(name).is_some() {
@ -298,7 +306,7 @@ mod tests {
}
#[test]
fn unused_pat_param_flake_output() {
fn flake_output_self() {
// Warn `self`.
check(
"
@ -315,6 +323,31 @@ mod tests {
#- /flake.nix
{
outputs = { self, $0nixpkgs }: { };
}
",
);
}
// https://github.com/oxalica/nil/issues/73
#[test]
fn flake_output_with_universal() {
// Don't warn pat parameters for automatic inputs.
check(
"
#- /flake.nix
{
outputs = { self, nixpkgs, ... }@inputs:
import ./foo.nix inputs;
}
",
);
// The universal parameter itself is still warned.
check(
"
#- /flake.nix
{
outputs = { self, nixpkgs, ... }@$0inputs: { };
}
",
);