language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ability impls that don't shadow can end up resolving to the member def

Browse source
This commit is contained in:
Ayaz Hafiz 2022-09-21 10:32:25 -05:00
parent b7b0af0d45
commit 01815ad23f
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/compiler/can/src/def.rs
View file

@ -495,8 +495,20 @@ fn canonicalize_claimed_ability_impl<'a>(
.or_else(|| scope.lookup_str(label_str, region).ok());
match opt_impl_symbol {
Some(impl_symbol) => Ok((member_symbol, impl_symbol)),
None => {
// It's possible that even if we find a symbol it is still only the member
// definition symbol, for example when the ability is defined in the same
// module as an implementer:
//
// Eq has eq : a, a -> U64 | a has Eq
//
// A := U8 has [Eq {eq}]
//
// So, do a final check that the implementation symbol is not resolved directly
// to the member.
Some(impl_symbol) if impl_symbol != member_symbol => {
Ok((member_symbol, impl_symbol))
}
_ => {
env.problem(Problem::ImplementationNotFound {
member: member_symbol,
region: label.region,