language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Share stripping of ignorable strings in has_error helper

Browse source
This commit is contained in:
David Smith 2023-05-17 10:08:16 -04:00
parent 58cb8352bb
commit 051fca2f68
No known key found for this signature in database
GPG key ID: 979D8D09D9570EED
3 changed files with 25 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/cli_utils/src/helpers.rs
View file

@ -105,13 +105,23 @@ where
}
pub fn has_error(stderr: &str) -> bool {
let is_reporting_runtime = stderr.starts_with("runtime: ") && stderr.ends_with("ms\n");
let stderr_stripped = stderr
.replacen("🔨 Rebuilding platform...\n", "", 1)
// for some reason, llvm prints out this warning when targeting windows
.replacen(
"warning: ignoring debug info with an invalid version (0) in app\r\n",
"",
1,
);
let is_clean = stderr.is_empty() ||
let is_reporting_runtime =
stderr_stripped.starts_with("runtime: ") && stderr_stripped.ends_with("ms\n");
let is_clean = stderr_stripped.is_empty() ||
is_reporting_runtime ||
// macOS ld reports this warning, but if we remove -undefined dynamic_lookup,
// linking stops working properly.
stderr.trim() == "ld: warning: -undefined dynamic_lookup may not work with chained fixups";
stderr_stripped.trim() == "ld: warning: -undefined dynamic_lookup may not work with chained fixups";
!is_clean
}