language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-02 19:32:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add a clarifying comment about prefetching

Browse source
This commit is contained in:
Richard Feldman 2023-09-11 15:08:45 -04:00
parent 783eb9380f
commit 061d2e5df6
No known key found for this signature in database
GPG key ID: F1F21AA5B1D9E43B
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/compiler/parse/src/src64.rs
View file

@ -263,7 +263,7 @@ unsafe fn allocate_and_pad_with_newlines(arena: &Bump, capacity: usize) -> Optio
// Prefetch the third 64-byte chunk, using min() to branchlessly avoid prefetching an address we might not own. // Prefetch the third 64-byte chunk, using min() to branchlessly avoid prefetching an address we might not own.
prefetch_read(buf_ptr, 128.min(last_chunk_offset)); prefetch_read(buf_ptr, 128.min(last_chunk_offset));
// Further prefetching will happen in the tokenization loop. Now that we've prefetched the first 3 pages, // Further prefetching can happen in the tokenization loop. Now that we've prefetched the first 3 pages,
// we should be able to prefetch the others in the loop with enough time before the tokenizer arrives there. // we should be able to prefetch the others in the loop with enough time before the tokenizer arrives there.
} }
@ -353,6 +353,8 @@ fn prefetch_read<T>(non_null_ptr: NonNull<T>, offset: usize) {
in(reg) non_null_ptr.as_ptr().add(offset) in(reg) non_null_ptr.as_ptr().add(offset)
); );
} }
// If we're not on x64 or aarch64, just do nothing!
} }
#[inline(always)] #[inline(always)]
@ -375,6 +377,8 @@ fn prefetch_readwrite<T>(non_null_ptr: NonNull<T>, offset: usize) {
in(reg) non_null_ptr.as_ptr().add(offset) in(reg) non_null_ptr.as_ptr().add(offset)
); );
} }
// If we're not on x64 or aarch64, just do nothing!
} }
#[cfg(test)] #[cfg(test)]