language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 14:24:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Prefer "tags are missing" error messages

Browse source
This commit is contained in:
Ayaz Hafiz 2022-10-25 18:00:09 -05:00
parent ec4285c1dd
commit 0707739cfc
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/reporting/src/error/type.rs
View file

@ -3191,7 +3191,8 @@ fn diff_tag_union<'b>(
let all_fields_shared = left.peek().is_none() && right.peek().is_none(); let all_fields_shared = left.peek().is_none() && right.peek().is_none();
let status = match (ext_has_fixed_fields(&ext1), ext_has_fixed_fields(&ext2)) { let status = match (ext_has_fixed_fields(&ext1), ext_has_fixed_fields(&ext2)) {
(true, true) => match (left.peek(), right.peek()) { (false, false) => Status::Similar,
_ => match (left.peek(), right.peek()) {
(Some((f, _, _, _)), Some(_)) => Status::Different(vec![Problem::TagTypo( (Some((f, _, _, _)), Some(_)) => Status::Different(vec![Problem::TagTypo(
f.clone(), f.clone(),
fields2.keys().cloned().collect(), fields2.keys().cloned().collect(),
@ -3210,21 +3211,6 @@ fn diff_tag_union<'b>(
} }
(None, None) => Status::Similar, (None, None) => Status::Similar,
}, },
(false, true) => match left.peek() {
Some((f, _, _, _)) => Status::Different(vec![Problem::TagTypo(
f.clone(),
fields2.keys().cloned().collect(),
)]),
None => Status::Similar,
},
(true, false) => match right.peek() {
Some((f, _, _, _)) => Status::Different(vec![Problem::TagTypo(
f.clone(),
fields1.keys().cloned().collect(),
)]),
None => Status::Similar,
},
(false, false) => Status::Similar,
}; };
let ext_diff = tag_ext_to_diff(alloc, pol, ext1, ext2, &gen_usages1, &gen_usages2); let ext_diff = tag_ext_to_diff(alloc, pol, ext1, ext2, &gen_usages1, &gen_usages2);