language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-30 15:21:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #2798 from rtfeldman/wasm-fix-dec-isfinite

Browse source 
Wasm: fix Num.isFinite for Dec
This commit is contained in:
Richard Feldman 2022-04-04 20:58:46 -04:00 • committed by GitHub
commit 08466380df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
compiler/gen_wasm/src/low_level.rs
View file

@ -876,7 +876,8 @@ fn num_is_finite(backend: &mut WasmBackend<'_>, argument: Symbol) {
.storage .storage
.load_symbols(&mut backend.code_builder, &[argument]); .load_symbols(&mut backend.code_builder, &[argument]);
match value_type { match value_type {
ValueType::I32 | ValueType::I64 => backend.code_builder.i32_const(1), // always true for integers // Integers are always finite. Just return True.
ValueType::I32 | ValueType::I64 => backend.code_builder.i32_const(1),
ValueType::F32 => { ValueType::F32 => {
backend.code_builder.i32_reinterpret_f32(); backend.code_builder.i32_reinterpret_f32();
backend.code_builder.i32_const(0x7f80_0000); backend.code_builder.i32_const(0x7f80_0000);
@ -899,7 +900,10 @@ fn num_is_finite(backend: &mut WasmBackend<'_>, argument: Symbol) {
let (local_id, offset) = location.local_and_offset(backend.storage.stack_frame_pointer); let (local_id, offset) = location.local_and_offset(backend.storage.stack_frame_pointer);
match format { match format {
StackMemoryFormat::Int128 => backend.code_builder.i32_const(1), // Integers and fixed-point numbers are always finite. Just return True.
StackMemoryFormat::Int128 | StackMemoryFormat::Decimal => {
backend.code_builder.i32_const(1)
}
// f128 is not supported anywhere else but it's easy to support it here, so why not... // f128 is not supported anywhere else but it's easy to support it here, so why not...
StackMemoryFormat::Float128 => { StackMemoryFormat::Float128 => {
@ -911,15 +915,6 @@ fn num_is_finite(backend: &mut WasmBackend<'_>, argument: Symbol) {
backend.code_builder.i64_ne(); backend.code_builder.i64_ne();
} }
StackMemoryFormat::Decimal => {
backend.code_builder.get_local(local_id);
backend.code_builder.i64_load(Align::Bytes4, offset + 8);
backend.code_builder.i64_const(0x7100_0000_0000_0000);
backend.code_builder.i64_and();
backend.code_builder.i64_const(0x7100_0000_0000_0000);
backend.code_builder.i64_ne();
}
StackMemoryFormat::DataStructure => { StackMemoryFormat::DataStructure => {
internal_error!("Tried to perform NumIsFinite on a data structure") internal_error!("Tried to perform NumIsFinite on a data structure")
} }