language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-10-02 16:21:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Account for unwrapped structs in AccessAtIndex

Browse source
This commit is contained in:
Richard Feldman 2020-07-05 22:41:07 -04:00
parent 853462833c
commit 092df6ddb2
1 changed files with 20 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

30
compiler/gen/src/llvm/build.rs
View file

@ -632,19 +632,29 @@ pub fn build_expr<'a, 'ctx, 'env>(
is_unwrapped,
..
} if *is_unwrapped => {
use inkwell::values::BasicValueEnum::*;
let builder = env.builder;
// Get Struct val
// Since this is a one-element tag union, we get the correct struct immediately
let argument = build_expr(env, layout_ids, &scope, parent, expr).into_struct_value();
builder
.build_extract_value(
argument,
*index as u32,
env.arena.alloc(format!("tag_field_access_{}_", index)),
)
.unwrap()
// Since this is a one-element tag union, we get the underlying value
// right away. However, that struct might have only one field which
// is not zero-sized, which would make it unwrapped. If that happens,
// we must be
match build_expr(env, layout_ids, &scope, parent, expr) {
StructValue(argument) => builder
.build_extract_value(
argument,
*index as u32,
env.arena.alloc(format!("tag_field_access_{}_", index)),
)
.unwrap(),
other => {
// If it's not a Struct, that means it was unwrapped,
// so we should return it directly.
other
}
}
}
AccessAtIndex {