language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 21:39:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Add nice error message for Problem::InvalidUrl(UrlProblem::DownloadTooBig)

Browse source 
Contributes to #5487
This commit is contained in:
Fábio Beirão 2023-06-02 12:39:42 +02:00
parent bf22a2520e
commit 0a0045675b
No known key found for this signature in database
GPG key ID: 13FD3A2130278AAE
1 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/reporting/src/report.rs
View file

@ -1509,20 +1509,31 @@ pub fn to_https_problem_report<'b>(
severity: Severity::Fatal,
}
}
_ => {
// TODO: once all patterns are there, we should remove the _
Problem::DownloadTooBig(content_len) => {
let doc = alloc.stack([
alloc.reflow(r"Something went wrong while downloading this URL:"),
alloc.reflow(r"I was trying to download this URL:"),
alloc
.string((&url).to_string())
.annotate(Annotation::Url)
.indent(4),
alloc.concat([
alloc.reflow(r"But the server stated this file is "),
// TODO: evaluate taking a dependency on https://docs.rs/byte-unit/ to provide a better formatting
alloc.string(format!("{} bytes", content_len)).annotate(Annotation::Keyword),
alloc.reflow(r" in size. This is larger that the maximum size I can handle (around 32 GB)."),
]),
alloc.concat([
alloc.tip(),
alloc.reflow(r"Check that you have the correct URL for this package/platform. "),
alloc.reflow(r"If you do, you should contact the package/platform's author and "),
alloc.reflow(r"notify them about this issue."),
]),
]);
Report {
filename: "UNKNOWN.roc".into(),
doc,
title: "todo!".to_string(),
title: "FILE TOO LARGE".to_string(),
severity: Severity::Fatal,
}
}