language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-04 04:08:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix approximately a bajillion fmt and parsing bugs

Browse source 
(discovered by fuzzing)

There's more to come, but this seems like a good batch for now.
This commit is contained in:
Joshua Warner 2023-01-11 19:44:29 -08:00
parent 8f62eeaf7e
commit 0b8e68f70d
No known key found for this signature in database
GPG key ID: 89AD497003F93FDD
68 changed files with 1011 additions and 229 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/compiler/test_syntax/tests/snapshots/fail/when_outdented_branch.expr.result-ast
View file

@ -1 +1 @@
Expr(BadExprEnd(@20), @0)
Expr(BadExprEnd(@22), @0)

3
crates/compiler/test_syntax/tests/snapshots/pass/call_with_newlines.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
f
-5
2

25
crates/compiler/test_syntax/tests/snapshots/pass/call_with_newlines.expr.result-ast Normal file
View file

@ -0,0 +1,25 @@
Apply(
@0-1 SpaceAfter(
Var {
module_name: "",
ident: "f",
},
[
Newline,
],
),
[
@2-4 Num(
"-5",
),
@5-6 SpaceBefore(
Num(
"2",
),
[
Newline,
],
),
],
Space,
)

3
crates/compiler/test_syntax/tests/snapshots/pass/call_with_newlines.expr.roc Normal file
View file

@ -0,0 +1,3 @@
f
-5
2

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_annotation.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
F : e #
q

42
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_annotation.expr.result-ast Normal file
View file

@ -0,0 +1,42 @@
Defs(
Defs {
tags: [
Index(0),
],
regions: [
@0-3,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @0-1 "F",
vars: [],
},
ann: @2-3 BoundVariable(
"e",
),
},
],
value_defs: [],
},
@7-8 SpaceBefore(
Var {
module_name: "",
ident: "q",
},
[
LineComment(
"",
),
Newline,
Newline,
],
),
)

4
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_annotation.expr.roc Normal file
View file

@ -0,0 +1,4 @@
F:e#
q

1
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_expr_in_parens.expr.formatted.roc Normal file
View file

@ -0,0 +1 @@
i # abc

13
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_expr_in_parens.expr.result-ast Normal file
View file

@ -0,0 +1,13 @@
ParensAround(
SpaceAfter(
Var {
module_name: "",
ident: "i",
},
[
LineComment(
"abc",
),
],
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_expr_in_parens.expr.roc Normal file
View file

@ -0,0 +1,2 @@
(i#abc
)

4
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_tag_in_def.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
Z #
h
: a
j

54
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_tag_in_def.expr.result-ast Normal file
View file

@ -0,0 +1,54 @@
Defs(
Defs {
tags: [
Index(0),
],
regions: [
@0-7,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @0-1 "Z",
vars: [
@3-4 SpaceAfter(
SpaceBefore(
Identifier(
"h",
),
[
LineComment(
"",
),
],
),
[
Newline,
],
),
],
},
ann: @6-7 BoundVariable(
"a",
),
},
],
value_defs: [],
},
@8-9 SpaceBefore(
Var {
module_name: "",
ident: "j",
},
[
Newline,
],
),
)

4
crates/compiler/test_syntax/tests/snapshots/pass/comment_after_tag_in_def.expr.roc Normal file
View file

@ -0,0 +1,4 @@
Z#
h
:a
j

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_colon_def.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
w #
: n
Q

43
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_colon_def.expr.result-ast Normal file
View file

@ -0,0 +1,43 @@
Defs(
Defs {
tags: [
Index(2147483648),
],
regions: [
@0-5,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [],
value_defs: [
Annotation(
@0-1 SpaceAfter(
Identifier(
"w",
),
[
LineComment(
"",
),
],
),
@4-5 BoundVariable(
"n",
),
),
],
},
@6-7 SpaceBefore(
Tag(
"Q",
),
[
Newline,
],
),
)

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_colon_def.expr.roc Normal file
View file

@ -0,0 +1,3 @@
w#
:n
Q

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_equals_def.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
t #
= 3
e

44
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_equals_def.expr.result-ast Normal file
View file

@ -0,0 +1,44 @@
Defs(
Defs {
tags: [
Index(2147483648),
],
regions: [
@0-5,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [],
value_defs: [
Body(
@0-1 SpaceAfter(
Identifier(
"t",
),
[
LineComment(
"",
),
],
),
@4-5 Num(
"3",
),
),
],
},
@6-7 SpaceBefore(
Var {
module_name: "",
ident: "e",
},
[
Newline,
],
),
)

3
crates/compiler/test_syntax/tests/snapshots/pass/comment_before_equals_def.expr.roc Normal file
View file

@ -0,0 +1,3 @@
t#
=3
e

5
crates/compiler/test_syntax/tests/snapshots/pass/list_closing_indent_not_enough.expr.result-ast
View file

@ -16,8 +16,11 @@ Defs(
type_defs: [],
value_defs: [
Body(
@0-7 Malformed(
@0-7 MalformedIdent(
"my_list",
Underscore(
@3,
),
),
@10-58 List(
Collection {

5
crates/compiler/test_syntax/tests/snapshots/pass/list_closing_same_indent_no_trailing_comma.expr.result-ast
View file

@ -16,8 +16,11 @@ Defs(
type_defs: [],
value_defs: [
Body(
@0-7 Malformed(
@0-7 MalformedIdent(
"my_list",
Underscore(
@3,
),
),
@10-26 List(
[

5
crates/compiler/test_syntax/tests/snapshots/pass/list_closing_same_indent_with_trailing_comma.expr.result-ast
View file

@ -16,8 +16,11 @@ Defs(
type_defs: [],
value_defs: [
Body(
@0-7 Malformed(
@0-7 MalformedIdent(
"my_list",
Underscore(
@3,
),
),
@10-27 List(
Collection {

2
crates/compiler/test_syntax/tests/snapshots/pass/multi_backpassing_with_apply.expr.formatted.roc Normal file
View file

@ -0,0 +1,2 @@
(F 1), r <- a
W

29
crates/compiler/test_syntax/tests/snapshots/pass/multi_backpassing_with_apply.expr.result-ast Normal file
View file

@ -0,0 +1,29 @@
Backpassing(
[
@0-3 Apply(
@0-1 Tag(
"F",
),
[
@2-3 NumLiteral(
"1",
),
],
),
@5-6 Identifier(
"r",
),
],
@10-11 Var {
module_name: "",
ident: "a",
},
@12-13 SpaceBefore(
Tag(
"W",
),
[
Newline,
],
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/multi_backpassing_with_apply.expr.roc Normal file
View file

@ -0,0 +1,2 @@
F 1, r <- a
W

4
crates/compiler/test_syntax/tests/snapshots/pass/multiline_string_in_apply.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
e
"""
"\"
"""

23
crates/compiler/test_syntax/tests/snapshots/pass/multiline_string_in_apply.expr.result-ast Normal file
View file

@ -0,0 +1,23 @@
Apply(
@0-1 Var {
module_name: "",
ident: "e",
},
[
@1-10 Str(
Block(
[
[
Plaintext(
"\"",
),
EscapedChar(
DoubleQuote,
),
],
],
),
),
],
Space,
)

1
crates/compiler/test_syntax/tests/snapshots/pass/multiline_string_in_apply.expr.roc Normal file
View file

@ -0,0 +1 @@
e""""\""""

3
crates/compiler/test_syntax/tests/snapshots/pass/negate_multiline_string.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
!
"""
"""

8
crates/compiler/test_syntax/tests/snapshots/pass/negate_multiline_string.expr.result-ast Normal file
View file

@ -0,0 +1,8 @@
UnaryOp(
@1-7 Str(
Block(
[],
),
),
@0-1 Not,
)

1
crates/compiler/test_syntax/tests/snapshots/pass/negate_multiline_string.expr.roc Normal file
View file

@ -0,0 +1 @@
!""""""

4
crates/compiler/test_syntax/tests/snapshots/pass/negative_in_apply_def.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
a = A
-g
a
a

58
crates/compiler/test_syntax/tests/snapshots/pass/negative_in_apply_def.expr.result-ast Normal file
View file

@ -0,0 +1,58 @@
Defs(
Defs {
tags: [
Index(2147483648),
],
regions: [
@0-9,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [],
value_defs: [
Body(
@0-1 Identifier(
"a",
),
@2-9 Apply(
@2-3 SpaceAfter(
Tag(
"A",
),
[
Newline,
],
),
[
@5-7 UnaryOp(
@6-7 Var {
module_name: "",
ident: "g",
},
@5-6 Negate,
),
@8-9 Var {
module_name: "",
ident: "a",
},
],
Space,
),
),
],
},
@10-11 SpaceBefore(
Var {
module_name: "",
ident: "a",
},
[
Newline,
],
),
)

3
crates/compiler/test_syntax/tests/snapshots/pass/negative_in_apply_def.expr.roc Normal file
View file

@ -0,0 +1,3 @@
a=A
-g a
a

4
crates/compiler/test_syntax/tests/snapshots/pass/nested_def_without_newline.expr.formatted.roc Normal file
View file

@ -0,0 +1,4 @@
x =
a : n
4
_

64
crates/compiler/test_syntax/tests/snapshots/pass/nested_def_without_newline.expr.result-ast Normal file
View file

@ -0,0 +1,64 @@
Defs(
Defs {
tags: [
Index(2147483648),
],
regions: [
@0-7,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [],
value_defs: [
Body(
@0-1 Identifier(
"x",
),
@2-7 Defs(
Defs {
tags: [
Index(2147483648),
],
regions: [
@2-5,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [],
value_defs: [
Annotation(
@2-3 Identifier(
"a",
),
@4-5 BoundVariable(
"n",
),
),
],
},
@6-7 Num(
"4",
),
),
),
],
},
@8-9 SpaceBefore(
Underscore(
"",
),
[
Newline,
],
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/nested_def_without_newline.expr.roc Normal file
View file

@ -0,0 +1,2 @@
x=a:n 4
_

1
crates/compiler/test_syntax/tests/snapshots/pass/newline_after_paren.expr.formatted.roc Normal file
View file

@ -0,0 +1 @@
A

10
crates/compiler/test_syntax/tests/snapshots/pass/newline_after_paren.expr.result-ast Normal file
View file

@ -0,0 +1,10 @@
ParensAround(
SpaceBefore(
Tag(
"A",
),
[
Newline,
],
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/newline_after_paren.expr.roc Normal file
View file

@ -0,0 +1,2 @@
(
A)

5
crates/compiler/test_syntax/tests/snapshots/pass/newline_before_operator_with_defs.expr.formatted.roc Normal file
View file

@ -0,0 +1,5 @@
7
== (
Q : c
42
)

49
crates/compiler/test_syntax/tests/snapshots/pass/newline_before_operator_with_defs.expr.result-ast Normal file
View file

@ -0,0 +1,49 @@
BinOps(
[
(
@0-1 SpaceAfter(
Num(
"7",
),
[
Newline,
],
),
@2-4 Equals,
),
],
@5-11 ParensAround(
Defs(
Defs {
tags: [
Index(0),
],
regions: [
@5-8,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @5-6 "Q",
vars: [],
},
ann: @7-8 BoundVariable(
"c",
),
},
],
value_defs: [],
},
@9-11 Num(
"42",
),
),
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/newline_before_operator_with_defs.expr.roc Normal file
View file

@ -0,0 +1,2 @@
7
==(Q:c 42)

3
crates/compiler/test_syntax/tests/snapshots/pass/newline_in_type_alias_application.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
A : A
A
p

51
crates/compiler/test_syntax/tests/snapshots/pass/newline_in_type_alias_application.expr.result-ast Normal file
View file

@ -0,0 +1,51 @@
Defs(
Defs {
tags: [
Index(0),
],
regions: [
@0-6,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @0-1 "A",
vars: [],
},
ann: @2-6 Apply(
"",
"A",
[
@5-6 SpaceBefore(
Apply(
"",
"A",
[],
),
[
Newline,
],
),
],
),
},
],
value_defs: [],
},
@7-8 SpaceBefore(
Var {
module_name: "",
ident: "p",
},
[
Newline,
],
),
)

3
crates/compiler/test_syntax/tests/snapshots/pass/newline_in_type_alias_application.expr.roc Normal file
View file

@ -0,0 +1,3 @@
A:A
A
p

2
crates/compiler/test_syntax/tests/snapshots/pass/underscore_expr_in_def.expr.formatted.roc Normal file
View file

@ -0,0 +1,2 @@
J : R
n_p

42
crates/compiler/test_syntax/tests/snapshots/pass/underscore_expr_in_def.expr.result-ast Normal file
View file

@ -0,0 +1,42 @@
Defs(
Defs {
tags: [
Index(0),
],
regions: [
@0-3,
],
space_before: [
Slice(start = 0, length = 0),
],
space_after: [
Slice(start = 0, length = 0),
],
spaces: [],
type_defs: [
Alias {
header: TypeHeader {
name: @0-1 "J",
vars: [],
},
ann: @2-3 Apply(
"",
"R",
[],
),
},
],
value_defs: [],
},
@5-8 SpaceBefore(
MalformedIdent(
"n_p",
Underscore(
@7,
),
),
[
Newline,
],
),
)

2
crates/compiler/test_syntax/tests/snapshots/pass/underscore_expr_in_def.expr.roc Normal file
View file

@ -0,0 +1,2 @@
J:R
n_p

3
crates/compiler/test_syntax/tests/snapshots/pass/value_def_confusion.expr.formatted.roc Normal file
View file

@ -0,0 +1,3 @@
a : F
F : h
abc

55
crates/compiler/test_syntax/tests/snapshots/pass/value_def_confusion.expr.result-ast Normal file
View file

@ -0,0 +1,55 @@
Defs(
Defs {
tags: [
Index(2147483648),
Index(0),
],
regions: [
@0-3,
@4-8,
],
space_before: [
Slice(start = 0, length = 0),
Slice(start = 0, length = 1),
],
space_after: [
Slice(start = 0, length = 0),
Slice(start = 1, length = 0),
],
spaces: [
Newline,
],
type_defs: [
Alias {
header: TypeHeader {
name: @4-5 "F",
vars: [],
},
ann: @7-8 BoundVariable(
"h",
),
},
],
value_defs: [
Annotation(
@0-1 Identifier(
"a",
),
@2-3 Apply(
"",
"F",
[],
),
),
],
},
@9-12 SpaceBefore(
Var {
module_name: "",
ident: "abc",
},
[
Newline,
],
),
)

4
crates/compiler/test_syntax/tests/snapshots/pass/value_def_confusion.expr.roc Normal file
View file

@ -0,0 +1,4 @@
a:F
F
:h
abc