language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-11-01 21:40:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Move unexpected params warning to solve

Browse source
This commit is contained in:
Agus Zubiaga 2024-07-06 21:36:26 -03:00
parent 63e722f61d
commit 0cbb352a89
No known key found for this signature in database
18 changed files with 115 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/compiler/load_internal/src/file.rs
View file

@ -250,7 +250,6 @@ fn start_phase<'a>(
.clone();
let mut aliases = MutMap::default();
let mut modules_expecting_params = VecSet::default();
let mut abilities_store = PendingAbilitiesStore::default();
for imported in parsed.available_modules.keys() {
@ -294,10 +293,6 @@ fn start_phase<'a>(
.union(import_store.closure_from_imported(exposed_symbols));
}
}
if state.module_cache.param_patterns.contains_key(imported) {
modules_expecting_params.insert(*imported);
}
}
let skip_constraint_gen = {
@ -309,7 +304,6 @@ fn start_phase<'a>(
BuildTask::CanonicalizeAndConstrain {
parsed,
dep_idents,
modules_expecting_params,
exposed_symbols,
qualified_module_ids,
aliases,
@ -889,7 +883,6 @@ enum BuildTask<'a> {
CanonicalizeAndConstrain {
parsed: ParsedModule<'a>,
qualified_module_ids: PackageModuleIds<'a>,
modules_expecting_params: VecSet<ModuleId>,
dep_idents: IdentIdsByModule,
exposed_symbols: VecSet<Symbol>,
aliases: MutMap<Symbol, Alias>,
@ -5001,7 +4994,6 @@ fn canonicalize_and_constrain<'a>(
arena: &'a Bump,
qualified_module_ids: &'a PackageModuleIds<'a>,
dep_idents: IdentIdsByModule,
modules_expecting_params: VecSet<ModuleId>,
exposed_symbols: VecSet<Symbol>,
aliases: MutMap<Symbol, Alias>,
imported_abilities_state: PendingAbilitiesStore,
@ -5044,7 +5036,6 @@ fn canonicalize_and_constrain<'a>(
qualified_module_ids,
exposed_ident_ids,
&dep_idents,
modules_expecting_params,
aliases,
imported_abilities_state,
initial_scope,
@ -6207,7 +6198,6 @@ fn run_task<'a>(
parsed,
qualified_module_ids,
dep_idents,
modules_expecting_params,
exposed_symbols,
aliases,
abilities_store,
@ -6218,7 +6208,6 @@ fn run_task<'a>(
arena,
&qualified_module_ids,
dep_idents,
modules_expecting_params,
exposed_symbols,
aliases,
abilities_store,

15
crates/compiler/load_internal/tests/test_load.rs
View file

@ -315,6 +315,13 @@ fn expect_types(mut loaded_module: LoadedModule, mut expected_types: HashMap<&st
match declarations.declarations[index] {
Value | Function(_) | Recursive(_) | TailRecursive(_) => {
let body = declarations.expressions[index].clone();
if let roc_can::expr::Expr::ImportParams(_, _, None) = body.value {
// Skip import defs without params
continue;
}
let symbol = declarations.symbols[index].value;
let expr_var = declarations.variables[index];
@ -443,7 +450,13 @@ fn module_with_deps() {
match declarations.declarations[index] {
Value | Function(_) | Recursive(_) | TailRecursive(_) => {
def_count += 1;
let body = declarations.expressions[index].clone();
if let roc_can::expr::Expr::ImportParams(_, _, None) = body.value {
// Skip import defs without params
} else {
def_count += 1;
}
}
Destructure(_) => {
def_count += 1;