language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Merge pull request #6881 from roc-lang/empty-open-union

Browse source 
fix openness inference for empty tag
This commit is contained in:
Anton-4 2024-07-09 16:46:54 +02:00 • committed by GitHub
commit 0d9db5bf2d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/compiler/can/src/annotation.rs
View file

@ -968,19 +968,10 @@ fn can_annotation_help(
);
if tags.is_empty() {
match ext {
Some(_) => {
// just `a` does not mean the same as `[]`, so even
// if there are no fields, still make this a `TagUnion`,
// not an EmptyTagUnion
Type::TagUnion(
Default::default(),
TypeExtension::from_type(ext_type, is_implicit_openness),
)
}
None => Type::EmptyTagUnion,
}
} else {
let mut tag_types = can_tags(
env,
@ -1173,6 +1164,7 @@ fn can_extension_type(
local_aliases,
references,
);
if valid_extension_type(shallow_dealias_with_scope(scope, &ext_type)) {
if matches!(loc_ann.extract_spaces().item, TypeAnnotation::Wildcard)
&& matches!(ext_problem_kind, ExtensionTypeKind::TagUnion)

2
crates/compiler/uitest/tests/exhaustive/extend_uninhabited_without_opening_union.txt
View file

@ -3,5 +3,5 @@ app "test" provides [main] to "./platform"
walkHelp : {} -> [Continue {}, Break []]
main = when walkHelp {} is
# ^^^^^^^^^^^ [Break [], Continue {}]
# ^^^^^^^^^^^ [Break []w_a, Continue {}]
Continue {} -> {}