language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-26 13:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Warn on definitions that introduce no new variables

Browse source
This commit is contained in:
Ayaz Hafiz 2022-07-22 16:21:14 -04:00
parent beccc92c87
commit 0de32ac5a9
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 122 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/compiler/can/src/def.rs
View file

@ -905,7 +905,17 @@ fn canonicalize_value_defs<'a>(
let mut symbol_to_index: Vec<(IdentId, u32)> = Vec::with_capacity(pending_value_defs.len());
for (def_index, pending_def) in pending_value_defs.iter().enumerate() {
for (s, r) in BindingsFromPattern::new(pending_def.loc_pattern()) {
let mut new_bindings = BindingsFromPattern::new(pending_def.loc_pattern())
.into_iter()
.peekable();
if new_bindings.peek().is_none() {
env.problem(Problem::NoIdentifiersIntroduced(
pending_def.loc_pattern().region,
));
}
for (s, r) in new_bindings {
// store the top-level defs, used to ensure that closures won't capture them
if let PatternType::TopLevelDef = pattern_type {
env.top_level_symbols.insert(s);