language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 05:49:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Get rid of some dead deriving code

Browse source 
My favorite kind of dead code elimination
This commit is contained in:
Ayaz Hafiz 2022-07-13 12:44:33 -04:00
parent dc74803c18
commit 0dfdcf5523
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
1 changed files with 3 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

51
crates/compiler/derive/src/encoding.rs
View file

@ -15,26 +15,13 @@ use roc_module::symbol::{IdentIds, ModuleId, Symbol};
use roc_region::all::{Loc, Region};
use roc_types::subs::{
instantiate_rigids, Content, ExhaustiveMark, FlatType, GetSubsSlice, LambdaSet, OptVariable,
RecordFields, RedundantMark, Subs, SubsFmtContent, SubsSlice, UnionLambdas, UnionTags,
Variable, VariableSubsSlice,
RecordFields, RedundantMark, Subs, SubsSlice, UnionLambdas, UnionTags, Variable,
VariableSubsSlice,
};
use roc_types::types::{AliasKind, RecordField};
use roc_types::types::RecordField;
use crate::{synth_var, DerivedBody, DERIVED_SYNTH};
macro_rules! bad_input {
($subs:expr, $var:expr) => {
bad_input!($subs, $var, "Invalid content")
};
($subs:expr, $var:expr, $msg:expr) => {
internal_error!(
"{:?} for toEncoder deriver: {:?}",
$msg,
SubsFmtContent($subs.get_content_without_compacting($var), $subs)
)
};
}
pub(crate) struct Env<'a> {
/// NB: This **must** be subs for the derive module!
pub subs: &'a mut Subs,
@ -181,38 +168,6 @@ impl Env<'_> {
}
}
// TODO: decide whether it will be better to pass the whole signature, or just the argument type.
// For now we are only using the argument type for convinience of testing.
#[allow(dead_code)]
fn verify_signature(env: &mut Env<'_>, signature: Variable) {
// Verify the signature is what we expect: input -> Encoder fmt | fmt has EncoderFormatting
// and get the input type
match env.subs.get_content_without_compacting(signature) {
Content::Structure(FlatType::Func(input, _, output)) => {
// Check the output is Encoder fmt | fmt has EncoderFormatting
match env.subs.get_content_without_compacting(*output) {
Content::Alias(Symbol::ENCODE_ENCODER, args, _, AliasKind::Opaque) => {
match env.subs.get_subs_slice(args.all_variables()) {
[one] => match env.subs.get_content_without_compacting(*one) {
Content::FlexAbleVar(_, Symbol::ENCODE_ENCODERFORMATTING) => {}
_ => bad_input!(env.subs, signature),
},
_ => bad_input!(env.subs, signature),
}
}
_ => bad_input!(env.subs, signature),
}
// Get the only parameter into toEncoder
match env.subs.get_subs_slice(*input) {
[one] => *one,
_ => bad_input!(env.subs, signature),
}
}
_ => bad_input!(env.subs, signature),
};
}
pub(crate) fn derive_to_encoder(
env: &mut Env<'_>,
key: FlatEncodableKey,