language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-28 06:14:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Don't pass around an unnecessary Env

Browse source
This commit is contained in:
Richard Feldman 2022-05-04 20:45:51 -04:00
parent db96f3d208
commit 0f1e1d7659
No known key found for this signature in database
GPG key ID: 7E4127D1E4241798
3 changed files with 3 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

12
compiler/solve/src/solve.rs
View file

@ -496,7 +496,6 @@ struct State {
pub fn run(
constraints: &Constraints,
env: &Env,
problems: &mut Vec<TypeError>,
mut subs: Subs,
aliases: &mut Aliases,
@ -505,7 +504,6 @@ pub fn run(
) -> (Solved<Subs>, Env) {
let env = run_in_place(
constraints,
env,
problems,
&mut subs,
aliases,
@ -517,9 +515,8 @@ pub fn run(
}
/// Modify an existing subs in-place instead
pub fn run_in_place(
fn run_in_place(
constraints: &Constraints,
env: &Env,
problems: &mut Vec<TypeError>,
subs: &mut Subs,
aliases: &mut Aliases,
@ -529,11 +526,10 @@ pub fn run_in_place(
let mut pools = Pools::default();
let state = State {
env: env.clone(),
env: Env::default(),
mark: Mark::NONE.next(),
};
let rank = Rank::toplevel();
let arena = Bump::new();
let mut deferred_must_implement_abilities = DeferredMustImplementAbility::default();
@ -541,7 +537,6 @@ pub fn run_in_place(
let state = solve(
&arena,
constraints,
env,
state,
rank,
&mut pools,
@ -600,7 +595,6 @@ enum Work<'a> {
fn solve(
arena: &Bump,
constraints: &Constraints,
env: &Env,
mut state: State,
rank: Rank,
pools: &mut Pools,
@ -612,7 +606,7 @@ fn solve(
deferred_must_implement_abilities: &mut DeferredMustImplementAbility,
) -> State {
let initial = Work::Constraint {
env,
env: &Env::default(),
rank,
constraint,
};