language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-27 13:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

simplify addition with negative imm

Browse source
This commit is contained in:
Folkert 2023-09-16 20:22:32 +02:00
parent 29daf4dd5e
commit 0f77a24a2d
No known key found for this signature in database
GPG key ID: 1F17F6FFD112B97C
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/compiler/gen_dev/src/generic64/aarch64.rs
View file

@ -1019,9 +1019,7 @@ impl Assembler<AArch64GeneralReg, AArch64FloatReg> for AArch64Assembler {
imm32: i32, imm32: i32,
) { ) {
if imm32 < 0 { if imm32 < 0 {
// add immediates must be signed, so we have to use a register here Self::sub_reg64_reg64_imm32(buf, dst, src, -imm32);
Self::mov_reg64_imm64(buf, dst, imm32 as i64);
add_reg64_reg64_reg64(buf, dst, src, dst);
} else if imm32 < 0xFFF { } else if imm32 < 0xFFF {
add_reg64_reg64_imm12(buf, dst, src, imm32 as u16); add_reg64_reg64_imm12(buf, dst, src, imm32 as u16);
} else { } else {
@ -1552,7 +1550,7 @@ impl Assembler<AArch64GeneralReg, AArch64FloatReg> for AArch64Assembler {
imm32: i32, imm32: i32,
) { ) {
if imm32 < 0 { if imm32 < 0 {
todo!("immediate subtractions with values less than 0"); Self::add_reg64_reg64_imm32(buf, dst, src, -imm32)
} else if imm32 < 0xFFF { } else if imm32 < 0xFFF {
sub_reg64_reg64_imm12(buf, dst, src, imm32 as u16); sub_reg64_reg64_imm12(buf, dst, src, imm32 as u16);
} else { } else {