language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-29 06:44:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Report incomplete ability implementations

Browse source
This commit is contained in:
Ayaz Hafiz 2022-04-12 18:24:10 -04:00
parent b86bf94d92
commit 127d435ff2
No known key found for this signature in database
GPG key ID: 0E2A37416A25EF58
4 changed files with 170 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

49
compiler/solve/src/solve.rs
View file

@ -1,5 +1,5 @@
use bumpalo::Bump;
use roc_can::abilities::AbilitiesStore;
use roc_can::abilities::{AbilitiesStore, MemberSpecialization};
use roc_can::constraint::Constraint::{self, *};
use roc_can::constraint::{Constraints, LetConstraint};
use roc_can::expected::{Expected, PExpected};
@ -76,6 +76,13 @@ pub enum TypeError {
CircularType(Region, Symbol, ErrorType),
BadType(roc_types::types::Problem),
UnexposedLookup(Symbol),
IncompleteAbilityImplementation {
// TODO(abilities): have general types here, not just opaques
typ: Symbol,
ability: Symbol,
specialized_members: Vec<Loc<Symbol>>,
missing_members: Vec<Loc<Symbol>>,
},
}
use roc_types::types::Alias;
@ -568,7 +575,34 @@ pub fn run_in_place(
&mut deferred_must_implement_abilities,
);
// TODO run through and check that all abilities are properly implemented
// Now that the module has been solved, we can run through and check all
// types claimed to implement abilities.
deferred_must_implement_abilities.dedup();
for MustImplementAbility { typ, ability } in deferred_must_implement_abilities.into_iter() {
let members_of_ability = abilities_store.members_of_ability(ability).unwrap();
let mut specialized_members = Vec::with_capacity(members_of_ability.len());
let mut missing_members = Vec::with_capacity(members_of_ability.len());
for &member in members_of_ability {
match abilities_store.get_specialization(member, typ) {
None => {
let root_data = abilities_store.member_def(member).unwrap();
missing_members.push(Loc::at(root_data.region, member));
}
Some(specialization) => {
specialized_members.push(Loc::at(specialization.region, member));
}
}
}
if !missing_members.is_empty() {
problems.push(TypeError::IncompleteAbilityImplementation {
typ,
ability,
specialized_members,
missing_members,
});
}
}
state.env
}
@ -1254,8 +1288,17 @@ fn check_ability_specialization(
"If there's more than one, the definition is ambiguous - this should be an error"
);
// This is a valid specialization! Record it.
let specialization_type = ability_implementations_for_specialization[0].typ;
abilities_store.register_specialization_for_type(specialization_type, root_symbol);
let specialization = MemberSpecialization {
symbol,
region: symbol_loc_var.region,
};
abilities_store.register_specialization_for_type(
root_symbol,
specialization_type,
specialization,
);
// Store the checks for what abilities must be implemented to be checked after the
// whole module is complete.