language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-08-03 19:58:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Nicer message for unhandled expr errors

Browse source
This commit is contained in:
Agus Zubiaga 2024-11-06 12:15:33 -03:00
parent b9a693c077
commit 160dbee943
No known key found for this signature in database
2 changed files with 91 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

30
crates/compiler/load/tests/test_reporting.rs
View file

@ -5821,6 +5821,36 @@ mod test_reporting {
"#
);
test_report!(
unhandled_parse_error,
indoc!(
r#"
app "test" provides [main] to "./platform"
42
"#
),
@r#"
── UNHANDLED PARSE ERROR in tmp/unhandled_parse_error/Test.roc ─────────────────
I got stuck while parsing this:
1│ app "test" provides [main] to "./platform"
2│
3│ 42
^
Here's the internal parse problem:
UnexpectedTopLevelExpr(@44)
Unfortunately, I'm not able to provide a more insightful error message
for this syntax problem yet. This is considered a bug in the compiler.
Note: If you'd like to contribute to Roc, this would be a good first issue!
"#
);
// https://github.com/roc-lang/roc/issues/1714
test_report!(
interpolate_concat_is_transparent_1714,

84
crates/reporting/src/error/parse.rs
View file

@ -703,30 +703,68 @@ fn to_expr_report<'a>(
EExpr::Return(EReturn::Space(parse_problem, pos), _) => {
to_space_report(alloc, lines, filename, parse_problem, *pos)
}
EExpr::End(_)
| EExpr::Dot(_)
| EExpr::Access(_)
| EExpr::UnaryNot(_)
| EExpr::UnaryNegate(_)
| EExpr::Pattern(_, _)
| EExpr::IndentDefBody(_)
| EExpr::IndentEquals(_)
| EExpr::IndentAnnotation(_)
| EExpr::Equals(_)
| EExpr::DoubleColon(_)
| EExpr::MalformedPattern(_)
| EExpr::BackpassComma(_)
| EExpr::BackpassContinue(_)
| EExpr::DbgContinue(_)
| EExpr::Underscore(_)
| EExpr::Crash(_)
| EExpr::Try(_)
| EExpr::RecordUpdateOldBuilderField(_)
| EExpr::RecordUpdateIgnoredField(_)
| EExpr::RecordBuilderOldBuilderField(_)
| EExpr::UnexpectedTopLevelExpr(_) => {
todo!("unhandled parse error: {:?}", parse_problem)
// If you're adding or changing syntax, please handle the case with a good error message
// above instead of adding more unhandled cases below.
EExpr::End(pos)
| EExpr::Dot(pos)
| EExpr::Access(pos)
| EExpr::UnaryNot(pos)
| EExpr::UnaryNegate(pos)
| EExpr::Pattern(_, pos)
| EExpr::IndentDefBody(pos)
| EExpr::IndentEquals(pos)
| EExpr::IndentAnnotation(pos)
| EExpr::Equals(pos)
| EExpr::DoubleColon(pos)
| EExpr::MalformedPattern(pos)
| EExpr::BackpassComma(pos)
| EExpr::BackpassContinue(pos)
| EExpr::DbgContinue(pos)
| EExpr::Underscore(pos)
| EExpr::Crash(pos)
| EExpr::Try(pos)
| EExpr::UnexpectedTopLevelExpr(pos) => {
to_unhandled_parse_error_report(alloc, lines, filename, parse_problem, *pos, start)
}
EExpr::RecordUpdateOldBuilderField(region)
| EExpr::RecordUpdateIgnoredField(region)
| EExpr::RecordBuilderOldBuilderField(region) => to_unhandled_parse_error_report(
alloc,
lines,
filename,
parse_problem,
region.start(),
start,
),
}
}
fn to_unhandled_parse_error_report<'a>(
alloc: &'a RocDocAllocator<'a>,
lines: &LineInfo,
filename: PathBuf,
parse_problem: &roc_parse::parser::EExpr<'a>,
pos: Position,
start: Position,
) -> Report<'a> {
let severity = Severity::Fatal;
let surroundings = Region::new(start, pos);
let region = LineColumnRegion::from_pos(lines.convert_pos(pos));
let doc = alloc.stack([
alloc.reflow("I got stuck while parsing this:"),
alloc.region_with_subregion(lines.convert_region(surroundings), region, severity),
alloc.reflow("Here's the internal parse problem:"),
alloc.text(format!("{:?}", parse_problem)).indent(4),
alloc.reflow("Unfortunately, I'm not able to provide a more insightful error message for this syntax problem yet. This is considered a bug in the compiler."),
alloc.note("If you'd like to contribute to Roc, this would be a good first issue!")
]);
Report {
filename,
doc,
title: "UNHANDLED PARSE ERROR".to_string(),
severity,
}
}