language-servers/roc
1
0
Fork 0
mirror of https://github.com/roc-lang/roc.git synced 2025-09-30 15:21:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Cleanup comments

Browse source
This commit is contained in:
Brendan Hansknecht 2021-08-20 20:54:48 -07:00
parent bf4d5d39aa
commit 16c929d33a
1 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

21
linker/src/lib.rs
View file

@ -369,7 +369,6 @@ pub fn preprocess(matches: &ArgMatches) -> io::Result<i32> {
}
let text_disassembly_duration = text_disassembly_start.elapsed().unwrap();
// TODO: Store all this data in a nice format.
let scanning_dynamic_deps_start = SystemTime::now();
let dyn_sec = match exec_obj.section_by_name(".dynamic") {
@ -484,16 +483,6 @@ pub fn preprocess(matches: &ArgMatches) -> io::Result<i32> {
println!("SH Entry Count: {}", sh_num);
}
// TODO: Potentially create a version of the executable with certain dynamic information deleted (changing offset may break stuff so be careful).
// Remove shared library dependencies.
// Also modify the PLT entries such that they just are jumps to the app functions. They will be used for indirect calls.
// Add regular symbols pointing to 0 for the app functions (maybe not needed if it is just link metadata).
// We have to be really carefull here. If we change the size or address of any section, it will mess with offsets.
// Must likely we want to null out data. If we have to go through and update every relative offset, this will be much more complex.
// Potentially we can take advantage of virtual address to avoid actually needing to shift any offsets.
// It may be fine to just add some of this information to the metadata instead and deal with it on final exec creation.
// If we are copying the exec to a new location in the background anyway it may be basically free.
if verbose {
println!();
println!("{:?}", md);
@ -510,6 +499,16 @@ pub fn preprocess(matches: &ArgMatches) -> io::Result<i32> {
let total_duration = total_start.elapsed().unwrap();
// TODO: Potentially create a version of the executable with certain dynamic information deleted (changing offset may break stuff so be careful).
// Remove shared library dependencies.
// Also modify the PLT entries such that they just are jumps to the app functions. They will be used for indirect calls.
// Add regular symbols pointing to 0 for the app functions (maybe not needed if it is just link metadata).
// We have to be really carefull here. If we change the size or address of any section, it will mess with offsets.
// Must likely we want to null out data. If we have to go through and update every relative offset, this will be much more complex.
// Potentially we can take advantage of virtual address to avoid actually needing to shift any offsets.
// It may be fine to just add some of this information to the metadata instead and deal with it on final exec creation.
// If we are copying the exec to a new location in the background anyway it may be basically free.
println!();
println!("Timings");
report_timing("Shared Library Processing", shared_lib_processing_duration);